| Message ID | 1304771519.2227.6.camel@x61.thuisdomein |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
> iwl4965_rate_control_register() prints a message at KERN_ERR level. > - pr_err("Registering 4965 rate control operations\n"); Yes, I noticed this message on boot too and found it a tad confusing... ('Rate control operations'?? 4,965 of them?) :-) At least I know what it is now. Thanks, Paul. Julie -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, May 07, 2011 at 02:31:59PM +0200, Paul Bolle wrote: > iwl4965_rate_control_register() prints a message at KERN_ERR level. It > looks like it's just a debugging message, so pr_err() seems to be > overdone. But none of the similar functions in drivers/net/wireless > print a message, so let's just drop it entirely. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Previously sent for (I guess) v2.6.39-rc2. Still present in v2.6.39-rc6. This patch is already applied in wireless-next ... commit a22e93f5d819f11d2a2d6332e20ff5b462e5c208 Author: Paul Bolle <pebolle@tiscali.nl> Date: Thu Apr 7 20:40:32 2011 +0200 iwl4965: drop a lone pr_err() iwl4965_rate_control_register() prints a message at KERN_ERR level. It looks like it's just a debugging message, so pr_err() seems to be overdone. But none of the similar functions in drivers/net/wireless print a message, so let's just drop it. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: John W. Linville <linville@tuxdriver.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c index 31ac672..8950939 100644 --- a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c +++ b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c @@ -2860,7 +2860,6 @@ static struct rate_control_ops rs_4965_ops = { int iwl4965_rate_control_register(void) { - pr_err("Registering 4965 rate control operations\n"); return ieee80211_rate_control_register(&rs_4965_ops); }
iwl4965_rate_control_register() prints a message at KERN_ERR level. It looks like it's just a debugging message, so pr_err() seems to be overdone. But none of the similar functions in drivers/net/wireless print a message, so let's just drop it entirely. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Previously sent for (I guess) v2.6.39-rc2. Still present in v2.6.39-rc6. drivers/net/wireless/iwlegacy/iwl-4965-rs.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)