From patchwork Sat Apr 30 18:29:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rabin Vincent X-Patchwork-Id: 93507 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D96EDB6EED for ; Sun, 1 May 2011 04:29:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882Ab1D3S27 (ORCPT ); Sat, 30 Apr 2011 14:28:59 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:33310 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986Ab1D3S26 (ORCPT ); Sat, 30 Apr 2011 14:28:58 -0400 Received: by pzk9 with SMTP id 9so2563465pzk.19 for ; Sat, 30 Apr 2011 11:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:to:cc:subject:date:message-id :x-mailer; bh=dz9vp5GTdeCjf/YLPNuaRcxA8EHMr/KkvgvKvR13yos=; b=OdQv3Z5sBc7b35GRbunWNGb8FmyTD9oIrXwlUPSFMeBGWOn1WIzRoTdIwpzMtmxyMO oc21FBBUDmPfZomMXq3GBjKMPO/VwIdg7rk0AkV3JN04ulhJLTPZq3lcKdZegjWGSPJJ 7zFT1g2ud2IpbJcvRulV13omYzRPyFKhnQ6uc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=OqtHfwZaka5GyquVA94YVeHtgYk9xA8XmPmDY4UBY2JaX7p3rdYwM5aigEfuaUHI7Y KOnRdrGmND38EdP23+pcqR0VC4nkNe9lqqbjsQwEv30fNpkO44ETd5A8jKC6ZIo6DLUP sZ3OTBjNT+fRlOdZ9TrWevhEcuE/zJmzEmWXU= Received: by 10.68.46.36 with SMTP id s4mr5434537pbm.12.1304188138265; Sat, 30 Apr 2011 11:28:58 -0700 (PDT) Received: from localhost.localdomain ([59.164.102.98]) by mx.google.com with ESMTPS id y9sm9927pbp.24.2011.04.30.11.28.54 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Apr 2011 11:28:56 -0700 (PDT) From: Rabin Vincent To: steve.glendinning@smsc.com Cc: netdev@vger.kernel.org, Rabin Vincent Subject: [PATCH] smsc95xx: fix reset check Date: Sat, 30 Apr 2011 23:59:27 +0530 Message-Id: <1304188167-18152-1-git-send-email-rabin@rab.in> X-Mailer: git-send-email 1.7.4.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The reset loop check should check the MII_BMCR register value for BMCR_RESET rather than for MII_BMCR (the register address, which also happens to be zero). Signed-off-by: Rabin Vincent --- drivers/net/usb/smsc95xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 24f4b37..2b16d54 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -689,7 +689,7 @@ static int smsc95xx_phy_initialize(struct usbnet *dev) msleep(10); bmcr = smsc95xx_mdio_read(dev->net, dev->mii.phy_id, MII_BMCR); timeout++; - } while ((bmcr & MII_BMCR) && (timeout < 100)); + } while ((bmcr & BMCR_RESET) && (timeout < 100)); if (timeout >= 100) { netdev_warn(dev->net, "timeout on PHY Reset");