From patchwork Wed Mar 30 15:29:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Walter X-Patchwork-Id: 88932 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 12FE3B6F07 for ; Thu, 31 Mar 2011 02:34:51 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932136Ab1C3PeZ (ORCPT ); Wed, 30 Mar 2011 11:34:25 -0400 Received: from bn-scl-osf02.barracuda.com ([64.235.144.26]:14652 "EHLO bn-scl-osf02.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767Ab1C3PeX (ORCPT ); Wed, 30 Mar 2011 11:34:23 -0400 X-Greylist: delayed 647 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Mar 2011 11:34:23 EDT X-ASG-Debug-ID: 1301498615-638903690000-BZBGGp X-Barracuda-URL: http://10.8.0.46:80/cgi-bin/mark.cgi Received: from bn-scl-smrthst01.it.cudanet.local (bn-scl-smrthst01.it.cudanet.local [10.8.1.70]) by bn-scl-osf02.barracuda.com (Spam & Virus Firewall) with ESMTP id DE83E597B89; Wed, 30 Mar 2011 08:23:35 -0700 (PDT) Received: from bn-scl-smrthst01.it.cudanet.local (bn-scl-smrthst01.it.cudanet.local [10.8.1.70]) by bn-scl-osf02.barracuda.com with ESMTP id 7FAy3FTwCy3ovlMd (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Wed, 30 Mar 2011 08:23:35 -0700 (PDT) Received: from mail.phion.com ([10.0.0.121]) by bn-scl-smrthst01.it.cudanet.local (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id p2UFNU1I017708; Wed, 30 Mar 2011 08:23:31 -0700 Received: from xxx ([x.x.x.x]) by xxx with xxx; 30 Mar 2011 17:23:25 +0200 Received: from xxx ([x.x.x.x]) by xxx with xxx; Wed, 30 Mar 2011 17:23:25 +0200 X-ASG-Orig-Subj: [PATCH] ipv6: Add support for RTA_PREFSRC Subject: [PATCH] ipv6: Add support for RTA_PREFSRC From: Daniel Walter To: CC: Date: Wed, 30 Mar 2011 17:29:51 +0200 Message-ID: <1301498991.31789.187.camel@localhost> MIME-Version: 1.0 X-Mailer: Evolution 2.30.3 X-EXCLAIMER-MD-CONFIG: 23550527-0592-4512-8b29-af9b0339669a X-virus-status: This mail was not checked by phion-mailgateway X-Barracuda-Connect: bn-scl-smrthst01.it.cudanet.local[10.8.1.70] X-Barracuda-Start-Time: 1301498615 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-Virus-Scanned: by Barracuda Spam & Virus Firewall at barracuda.com X-Barracuda-Spam-Score: -1002.00 X-Barracuda-Spam-Status: No, SCORE=-1002.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=1000.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Daniel Walter [ipv6] Add support for RTA_PREFSRC This patch allows a user to select the preferred source address for a specific IPv6-Route. It can be set via a netlink message setting RTA_PREFSRC to a valid IPv6 address which must be up on the device the route will be bound to. Signed-off-by: Daniel Walter --- patch should apply clean against linux-2.3.39 HEAD include/linux/ipv6_route.h | 1 + include/net/ip6_fib.h | 2 + include/net/ip6_route.h | 1 + net/ipv6/addrconf.c | 2 + net/ipv6/ip6_output.c | 12 +++++-- net/ipv6/route.c | 68 ++++++++++++++++++++++++++++++++++++++++++-- 6 files changed, 79 insertions(+), 7 deletions(-) Daniel Walter Software Engineer Barracuda Networks AG Eduard-Bodem-Gasse 1 6020 Innsbruck Austria Phone: +43 (0) 508 100 Fax: +43 508 100 20 eMail: mailto:DWalter@barracuda.com Web: www.barracudanetworks.com, www.phion.com Barracuda Networks AG Vorsitzender des Aufsichtsrates/ Chairman of the supervisory board: Dean Drako Vorstand/ Executive Board: Dr. Wieland Alge, Mag. Guenter Klausner Sitz der Gesellschaft/ Registered office: 6020 Innsbruck, Austria Handelsgericht Innsbruck Firmenbuch/ Registration Number: 184392s UID-Nr/ VAT Number: ATU47509003 Diese Nachricht und allfaellige angehaengte Dokumente sind vertraulich und nur fuer den/die Adressaten bestimmt. Sollten Sie nicht der beabsichtigte Adressat sein, ist jede Offenlegung, Weiterleitung oder sonstige Verwendung dieser Information nicht gestattet. In diesem Fall bitten wir, den Absender zu verstaendigen und die Information zu vernichten. Fuer Uebermittlungsfehler oder sonstige Irrtuemer bei Uebermittlung besteht keine Haftung. This message and any attached files are confidential and intended solely for the addressee(s). Any publication, transmission or other use of the information by a person or entity other than the intended addressee is prohibited. If you receive this in error please contact the sender and delete the material. The sender does not accept liability for any errors or omissions as a result of the transmission. Barracuda Networks solutions are now available as virtual appliances. Visit www.barracudanetworks.com/vx for more information. diff --git a/include/linux/ipv6_route.h b/include/linux/ipv6_route.h index 1e7d8af..9845953 100644 --- a/include/linux/ipv6_route.h +++ b/include/linux/ipv6_route.h @@ -44,6 +44,7 @@ struct in6_rtmsg { struct in6_addr rtmsg_dst; struct in6_addr rtmsg_src; + struct in6_addr rtmsg_prefsrc; struct in6_addr rtmsg_gateway; __u32 rtmsg_type; __u16 rtmsg_dst_len; diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h index bc3cde0..98348d5 100644 --- a/include/net/ip6_fib.h +++ b/include/net/ip6_fib.h @@ -42,6 +42,7 @@ struct fib6_config { struct in6_addr fc_dst; struct in6_addr fc_src; + struct in6_addr fc_prefsrc; struct in6_addr fc_gateway; unsigned long fc_expires; @@ -107,6 +108,7 @@ struct rt6_info { struct rt6key rt6i_dst ____cacheline_aligned_in_smp; u32 rt6i_flags; struct rt6key rt6i_src; + struct rt6key rt6i_prefsrc; u32 rt6i_metric; u32 rt6i_peer_genid; diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index c850e5f..2b37c20 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -141,6 +141,7 @@ struct rt6_rtnl_dump_arg { extern int rt6_dump_route(struct rt6_info *rt, void *p_arg); extern void rt6_ifdown(struct net *net, struct net_device *dev); extern void rt6_mtu_change(struct net_device *dev, unsigned mtu); +extern void rt6_remove_prefsrc(struct inet6_ifaddr *ifp); /* diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 3daaf3c..26f9e14 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -825,6 +825,8 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp) dst_release(&rt->dst); } + /* clean up prefsrc entries */ + rt6_remove_prefsrc(ifp); out: in6_ifa_put(ifp); } diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 1820887..e2d8463 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -930,10 +930,14 @@ static int ip6_dst_lookup_tail(struct sock *sk, goto out_err_release; if (ipv6_addr_any(&fl6->saddr)) { - err = ipv6_dev_get_saddr(net, ip6_dst_idev(*dst)->dev, - &fl6->daddr, - sk ? inet6_sk(sk)->srcprefs : 0, - &fl6->saddr); + struct rt6_info *rt = (struct rt6_info *) *dst; + if (rt->rt6i_prefsrc.plen) + ipv6_addr_copy(&fl6->saddr, &rt->rt6i_prefsrc.addr); + else + err = ipv6_dev_get_saddr(net, ip6_dst_idev(*dst)->dev, + &fl6->daddr, + sk ? inet6_sk(sk)->srcprefs : 0, + &fl6->saddr); if (err) goto out_err_release; } diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 843406f..b53089d 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1325,6 +1325,20 @@ int ip6_route_add(struct fib6_config *cfg) if (dev == NULL) goto out; + /* check if prefsrc is set */ + if (!ipv6_addr_any(&cfg->fc_prefsrc)) { + struct in6_addr saddr_buf; + ipv6_addr_copy(&saddr_buf, &cfg->fc_prefsrc); + if (!ipv6_chk_addr(net, &saddr_buf, dev, 0)) { + printk(KERN_DEBUG "invalid pref_src\n"); + err = -EINVAL; + goto out; + } + ipv6_addr_copy(&rt->rt6i_prefsrc.addr, &cfg->fc_prefsrc); + rt->rt6i_prefsrc.plen = 128; + } else + rt->rt6i_prefsrc.plen = 0; + if (cfg->fc_flags & (RTF_GATEWAY | RTF_NONEXTHOP)) { rt->rt6i_nexthop = __neigh_lookup_errno(&nd_tbl, &rt->rt6i_gateway, dev); if (IS_ERR(rt->rt6i_nexthop)) { @@ -1893,6 +1907,7 @@ static void rtmsg_to_fib6_config(struct net *net, ipv6_addr_copy(&cfg->fc_dst, &rtmsg->rtmsg_dst); ipv6_addr_copy(&cfg->fc_src, &rtmsg->rtmsg_src); ipv6_addr_copy(&cfg->fc_gateway, &rtmsg->rtmsg_gateway); + ipv6_addr_copy(&cfg->fc_prefsrc, &rtmsg->rtmsg_prefsrc); } int ipv6_route_ioctl(struct net *net, unsigned int cmd, void __user *arg) @@ -2037,6 +2052,39 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev, return rt; } +/* remove deleted ip from prefsrc entries */ +struct arg_dev_net_ip { + struct net_device *dev; + struct net *net; + struct in6_addr *addr; +}; + +static int fib6_remove_prefsrc(struct rt6_info *rt, void *arg) +{ + struct net_device *dev = ((struct arg_dev_net_ip *)arg)->dev; + struct net *net = ((struct arg_dev_net_ip *)arg)->net; + struct in6_addr *addr = ((struct arg_dev_net_ip *)arg)->addr; + + if (((void *)rt->rt6i_dev == dev || dev == NULL) && + rt != net->ipv6.ip6_null_entry && + ipv6_addr_equal(addr, &rt->rt6i_prefsrc.addr)) { + /* remove prefsrc entry */ + rt->rt6i_prefsrc.plen = 0; + } + return 0; +} + +void rt6_remove_prefsrc(struct inet6_ifaddr *ifp) +{ + struct net *net = dev_net(ifp->idev->dev); + struct arg_dev_net_ip adni = { + .dev = ifp->idev->dev, + .net = net, + .addr = &ifp->addr, + }; + fib6_clean_all(net, fib6_remove_prefsrc, 0, &adni); +} + struct arg_dev_net { struct net_device *dev; struct net *net; @@ -2183,6 +2231,9 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh, nla_memcpy(&cfg->fc_src, tb[RTA_SRC], plen); } + if (tb[RTA_PREFSRC]) + nla_memcpy(&cfg->fc_prefsrc, tb[RTA_PREFSRC], 16); + if (tb[RTA_OIF]) cfg->fc_ifindex = nla_get_u32(tb[RTA_OIF]); @@ -2325,11 +2376,22 @@ static int rt6_fill_node(struct net *net, #endif NLA_PUT_U32(skb, RTA_IIF, iif); } else if (dst) { - struct inet6_dev *idev = ip6_dst_idev(&rt->dst); struct in6_addr saddr_buf; - if (ipv6_dev_get_saddr(net, idev ? idev->dev : NULL, - dst, 0, &saddr_buf) == 0) + if (rt->rt6i_prefsrc.plen) { + ipv6_addr_copy(&saddr_buf, &rt->rt6i_prefsrc.addr); NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf); + } else { + struct inet6_dev *idev = ip6_dst_idev(&rt->dst); + if (ipv6_dev_get_saddr(net, idev ? idev->dev : NULL, + dst, 0, &saddr_buf) == 0) + NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf); + } + } + + if (rt->rt6i_prefsrc.plen) { + struct in6_addr saddr_buf; + ipv6_addr_copy(&saddr_buf, &rt->rt6i_prefsrc.addr); + NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf); } if (rtnetlink_put_metrics(skb, dst_metrics_ptr(&rt->dst)) < 0)