| Message ID | 1300963120.3295.7.camel@localhost |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Jan, On 03/24/2011 11:38 AM, Jan Altenberg wrote: > Hi Bhupesh, > > as discussed I moved c_can_inval_msg_object() to the end of the if() > statement. That should fix the tx_bytes accounting. For me it's working > fine now. > > Signed-off-by: Jan Altenberg <jan@linutronix.de> > --- Could you please provide a proper commit message and put other comments below "---". Thanks, Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 110eda0..f895c04 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -704,7 +704,6 @@ static void c_can_do_tx(struct net_device *dev) for (/* nix */; (priv->tx_next - priv->tx_echo) > 0; priv->tx_echo++) { msg_obj_no = get_tx_echo_msg_obj(priv); - c_can_inval_msg_object(dev, 0, msg_obj_no); val = c_can_read_reg32(priv, &priv->regs->txrqst1); if (!(val & (1 << msg_obj_no))) { can_get_echo_skb(dev, @@ -713,6 +712,7 @@ static void c_can_do_tx(struct net_device *dev) &priv->regs->ifregs[0].msg_cntrl) & IF_MCONT_DLC_MASK; stats->tx_packets++; + c_can_inval_msg_object(dev, 0, msg_obj_no); } }
Hi Bhupesh, as discussed I moved c_can_inval_msg_object() to the end of the if() statement. That should fix the tx_bytes accounting. For me it's working fine now. Signed-off-by: Jan Altenberg <jan@linutronix.de> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html