From patchwork Mon Feb 14 10:54:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasiliy Kulikov X-Patchwork-Id: 83065 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44DC8B7172 for ; Mon, 14 Feb 2011 21:55:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621Ab1BNKy6 (ORCPT ); Mon, 14 Feb 2011 05:54:58 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:60639 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab1BNKyg (ORCPT ); Mon, 14 Feb 2011 05:54:36 -0500 Received: by mail-fx0-f46.google.com with SMTP id 20so5029530fxm.19 for ; Mon, 14 Feb 2011 02:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:to:cc:subject:date:message-id :x-mailer; bh=nlXjAdBpWLW94dhPgclLZ0Cg2Eq/vqoCtwD5dJKZJ+I=; b=W3xxEDp6dU9emWNG+BmtA1e54oQDs0qtTDPN5V5APtR4dXKJ3SKwnAXWx6BtyJkGWq z5UuOJ+9jE9njO7TBqGV4cc0rsIO9ogpf/Ftk62e113biEMjXm7oBJfhbODF7psdDSUu +PBuGKLmOo/n8WrS97HQ7rmXFTv3CuD9jzgqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=vcHu8VBKyvgbejinJuO4HArHP9RMzbPXsLtELsy2WxSRM2e6J93y5GxT37qaKW6O38 2viE+CZIFq3CM3CYTw0sLYJPlx0GMyVh0HdJk+9LDLK1As6ryKdAZqOPwh0LJ+mhh/NT /uPTtgGR2FfmyVAoytLdaeimH53HK8Ip2gPXY= Received: by 10.223.98.197 with SMTP id r5mr4349201fan.68.1297680875226; Mon, 14 Feb 2011 02:54:35 -0800 (PST) Received: from localhost (ppp91-77-40-235.pppoe.mtu-net.ru [91.77.40.235]) by mx.google.com with ESMTPS id c11sm974780fav.2.2011.02.14.02.54.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Feb 2011 02:54:34 -0800 (PST) From: Vasiliy Kulikov To: linux-kernel@vger.kernel.org Cc: security@kernel.org, Marcel Holtmann , "Gustavo F. Padovan" , "David S. Miller" , Tejun Heo , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] bluetooth: bnep: fix buffer overflow Date: Mon, 14 Feb 2011 13:54:31 +0300 Message-Id: <1297680871-11617-1-git-send-email-segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Struct ca is copied from userspace. It is not checked whether the "device" field is NULL terminated. This potentially leads to BUG() inside of alloc_netdev_mqs() and/or information leak by creating a device with a name made of contents of kernel stack. Signed-off-by: Vasiliy Kulikov --- Compile tested. net/bluetooth/bnep/sock.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/bluetooth/bnep/sock.c b/net/bluetooth/bnep/sock.c index 2862f53..30faaf1 100644 --- a/net/bluetooth/bnep/sock.c +++ b/net/bluetooth/bnep/sock.c @@ -88,6 +88,7 @@ static int bnep_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long sockfd_put(nsock); return -EBADFD; } + ca.device[sizeof(ca.device)-1] = 0; err = bnep_add_connection(&ca, nsock); if (!err) {