| Message ID | 1294021987-30385-1-git-send-email-sedat.dilek@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sedat Dilek <sedat.dilek@googlemail.com> Date: Mon, 3 Jan 2011 03:33:07 +0100 >>From my build.log: > > WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe() > The variable depca_isa_driver references > the function __init depca_isa_probe() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, > > This patch fixes the warning. > > Tested with linux-next (next-20101231) > > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> Again, mark depca_isa_probe() as __devinit to fix this bug. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 3, 2011 at 8:53 PM, David Miller <davem@davemloft.net> wrote: > From: Sedat Dilek <sedat.dilek@googlemail.com> > Date: Mon, 3 Jan 2011 03:33:07 +0100 > >>>From my build.log: >> >> WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe() >> The variable depca_isa_driver references >> the function __init depca_isa_probe() >> If the reference is valid then annotate the >> variable with __init* or __refdata (see linux/init.h) or name the variable: >> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, >> >> This patch fixes the warning. >> >> Tested with linux-next (next-20101231) >> >> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> > > Again, mark depca_isa_probe() as __devinit to fix this bug. > Thanks for the pointer, I have sent a new fixed version. - Sedat - -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/depca.c b/drivers/net/depca.c index 91b3846..dfaf746 100644 --- a/drivers/net/depca.c +++ b/drivers/net/depca.c @@ -405,7 +405,7 @@ static int __devexit depca_isa_remove(struct platform_device *pdev) return depca_device_remove(&pdev->dev); } -static struct platform_driver depca_isa_driver = { +static struct platform_driver depca_isa_driver __refdata = { .probe = depca_isa_probe, .remove = __devexit_p(depca_isa_remove), .driver = {
From my build.log: WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe() The variable depca_isa_driver references the function __init depca_isa_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, This patch fixes the warning. Tested with linux-next (next-20101231) Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> --- drivers/net/depca.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)