| Message ID | 1294021724-30337-1-git-send-email-sedat.dilek@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sedat Dilek <sedat.dilek@googlemail.com> Date: Mon, 3 Jan 2011 03:28:44 +0100 >>From my build.log: > > drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe() > The variable smsc_ircc_pnp_driver references > the function __init smsc_ircc_pnp_probe() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, > > This patch fixes the warning. > > Tested with linux-next (next-20101231) > > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> Just like your other patch, this fix is not correct. Mark smsc_ircc_pbp_probe() as __devinit instead of __init to fix this bug. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 3, 2011 at 8:53 PM, David Miller <davem@davemloft.net> wrote: > From: Sedat Dilek <sedat.dilek@googlemail.com> > Date: Mon, 3 Jan 2011 03:28:44 +0100 > >>>From my build.log: >> >> drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe() >> The variable smsc_ircc_pnp_driver references >> the function __init smsc_ircc_pnp_probe() >> If the reference is valid then annotate the >> variable with __init* or __refdata (see linux/init.h) or name the variable: >> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, >> >> This patch fixes the warning. >> >> Tested with linux-next (next-20101231) >> >> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> > > Just like your other patch, this fix is not correct. > > Mark smsc_ircc_pbp_probe() as __devinit instead of __init to fix > this bug. > I have sent a new fixed version. - Sedat - -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c index 8c57bfb..0ebd4a8 100644 --- a/drivers/net/irda/smsc-ircc2.c +++ b/drivers/net/irda/smsc-ircc2.c @@ -397,7 +397,7 @@ static int __init smsc_ircc_pnp_probe(struct pnp_dev *dev, return 0; } -static struct pnp_driver smsc_ircc_pnp_driver = { +static struct pnp_driver smsc_ircc_pnp_driver __refdata = { .name = "smsc-ircc2", .id_table = smsc_ircc_pnp_table, .probe = smsc_ircc_pnp_probe,
From my build.log: drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe() The variable smsc_ircc_pnp_driver references the function __init smsc_ircc_pnp_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, This patch fixes the warning. Tested with linux-next (next-20101231) Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> --- drivers/net/irda/smsc-ircc2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)