From patchwork Tue Nov 23 21:02:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Rosenberg X-Patchwork-Id: 72761 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A01A8B70D4 for ; Wed, 24 Nov 2010 08:02:25 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304Ab0KWVCU (ORCPT ); Tue, 23 Nov 2010 16:02:20 -0500 Received: from mx1.vsecurity.com ([209.67.252.12]:59723 "EHLO mx1.vsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917Ab0KWVCT (ORCPT ); Tue, 23 Nov 2010 16:02:19 -0500 Received: (qmail 73917 invoked from network); 23 Nov 2010 20:57:43 -0000 Received: from 75-144-181-206-newengland.hfc.comcastbusiness.net (HELO [172.20.64.61]) (drosenbe@[75.144.181.206]) (envelope-sender ) by mx1.vsecurity.com (qmail-ldap-1.03) with SMTP for ; 23 Nov 2010 20:57:43 -0000 Subject: [PATCH] DECnet: don't leak uninitialized stack byte From: Dan Rosenberg To: davem@davemloft.net Cc: netdev@vger.kernel.org Date: Tue, 23 Nov 2010 16:02:13 -0500 Message-ID: <1290546133.2276.10.camel@dan> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A single uninitialized padding byte is leaked to userspace. Signed-off-by: Dan Rosenberg CC: stable --- net/decnet/af_decnet.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index d6b93d1..cf38f52 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c @@ -1556,6 +1556,8 @@ static int __dn_getsockopt(struct socket *sock, int level,int optname, char __us if (r_len > sizeof(struct linkinfo_dn)) r_len = sizeof(struct linkinfo_dn); + memset(&link, 0, sizeof(link)); + switch(sock->state) { case SS_CONNECTING: link.idn_linkstate = LL_CONNECTING;