| Message ID | 128f4e57d59b23af14e65f1d46412626f0a51b0b.1552122585.git.gnault@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: keep refcount warning in reqsk_free() | expand |
From: Guillaume Nault <gnault@redhat.com> Date: Sat, 9 Mar 2019 10:26:53 +0100 > As Eric Dumazet said, "We do not have a way to tell if the req was ever > inserted in a hash table, so better play safe.". > Let's remove this comment, so that nobody will be tempted to drop the > WARN_ON_ONCE() line. > > Signed-off-by: Guillaume Nault <gnault@redhat.com> Applied, thanks.
diff --git a/include/net/request_sock.h b/include/net/request_sock.h index 347015515a7d..21a5243fecd1 100644 --- a/include/net/request_sock.h +++ b/include/net/request_sock.h @@ -108,7 +108,6 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener, static inline void reqsk_free(struct request_sock *req) { - /* temporary debugging */ WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0); req->rsk_ops->destructor(req);
As Eric Dumazet said, "We do not have a way to tell if the req was ever inserted in a hash table, so better play safe.". Let's remove this comment, so that nobody will be tempted to drop the WARN_ON_ONCE() line. Signed-off-by: Guillaume Nault <gnault@redhat.com> --- include/net/request_sock.h | 1 - 1 file changed, 1 deletion(-)