From patchwork Thu Oct 7 22:22:15 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 67108 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6FD54B70CB for ; Fri, 8 Oct 2010 09:22:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191Ab0JGWWV (ORCPT ); Thu, 7 Oct 2010 18:22:21 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:41111 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978Ab0JGWWU (ORCPT ); Thu, 7 Oct 2010 18:22:20 -0400 Received: by wyb28 with SMTP id 28so573292wyb.19 for ; Thu, 07 Oct 2010 15:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=+uibLIKylssi5xrIA+tco0pge8cPWoeVvT3bWYhO2Wg=; b=tsc635PPrRntDYAutm0yh7p+ozbxprcIZ6Y7B5o2AkrvvcuMCw6KttEytQMsZsSvhr M6xxkKikS+D/pJ+SQxqi1jlmXwyujTqXd/8wnwRusAggt9rpAEnuNqpWltqvzeN2us+3 WOhhju7xIQj8l0WhDfrXJM0wnX5zz9s0SlQu4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=weD2nXYm5oOVpPvtq/ZXTWuZOFyVMxZ6VsoL4qDDjTpyw2BDbIy5cEQ0PIhn9ikT/l TRJTL+nLuhWkVazVnV2h9uq9qjJS2g015JYAe2hHyCJfSN9Y0i8vhhhnWYCDDcSc++bH nARteIOKdDLTmlpxOdWUzYEPpEu3bQrphCNdw= Received: by 10.216.169.136 with SMTP id n8mr2900032wel.65.1286490138540; Thu, 07 Oct 2010 15:22:18 -0700 (PDT) Received: from [192.168.1.21] (167.144.72-86.rev.gaoland.net [86.72.144.167]) by mx.google.com with ESMTPS id v16sm1810008weq.8.2010.10.07.15.22.16 (version=SSLv3 cipher=RC4-MD5); Thu, 07 Oct 2010 15:22:17 -0700 (PDT) Subject: Re: IPv4: sysctl table check failed [was: mmotm 2010-10-07-14-08 uploaded] From: Eric Dumazet To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mm-commits@vger.kernel.org, ML netdev , "David S. Miller" In-Reply-To: <4CAE4479.6010606@gmail.com> References: <201010072140.o97Le69i025659@imap1.linux-foundation.org> <4CAE4479.6010606@gmail.com> Date: Fri, 08 Oct 2010 00:22:15 +0200 Message-ID: <1286490135.6536.75.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le vendredi 08 octobre 2010 à 00:06 +0200, Jiri Slaby a écrit : > On 10/07/2010 11:08 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2010-10-07-14-08 has been uploaded to > > Hi, I got bunch of "sysctl table check failed" below. All seem to be > related to ipv4: I would say, sysctl check is buggy :( min/max are optional [PATCH] sysctl: min/max bounds are optional sysctl check complains when proc_doulongvec_minmax or proc_doulongvec_ms_jiffies_minmax are used by a vector of longs (with more than one element), with no min or max value specified. This is unexpected, given we had a bug on this min/max handling :) Reported-by: Jiri Slaby Signed-off-by: Eric Dumazet Acked-by: WANG Cong --- kernel/sysctl_check.c | 9 --------- 1 file changed, 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c index 04cdcf7..10b90d8 100644 --- a/kernel/sysctl_check.c +++ b/kernel/sysctl_check.c @@ -143,15 +143,6 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) if (!table->maxlen) set_fail(&fail, table, "No maxlen"); } - if ((table->proc_handler == proc_doulongvec_minmax) || - (table->proc_handler == proc_doulongvec_ms_jiffies_minmax)) { - if (table->maxlen > sizeof (unsigned long)) { - if (!table->extra1) - set_fail(&fail, table, "No min"); - if (!table->extra2) - set_fail(&fail, table, "No max"); - } - } #ifdef CONFIG_PROC_SYSCTL if (table->procname && !table->proc_handler) set_fail(&fail, table, "No proc_handler");