diff mbox

MAINTAINERS: Add ehea driver as Supported

Message ID 1283365403-20877-1-git-send-email-leitao@linux.vnet.ibm.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Breno Leitao Sept. 1, 2010, 6:23 p.m. UTC
This change just add the IBM eHEA 10Gb network drivers as supported.

Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Eric Dumazet Sept. 1, 2010, 6:48 p.m. UTC | #1
Le mercredi 01 septembre 2010 à 15:23 -0300, leitao@linux.vnet.ibm.com a
écrit :
> This change just add the IBM eHEA 10Gb network drivers as supported.
> 
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>

Hi Breno.

This reminds me something I noticed in this driver.

In receive path, it unconditionally sets skb->ip_summed to
CHECKSUM_UNECESSARY, for _all_ frames, and this seems very suspect.

Shouldnt cqe->inet_checksum_value be checked or something ?

Are frames with bad checksum completely ignored at hardware level ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Sept. 1, 2010, 8:11 p.m. UTC | #2
From: leitao@linux.vnet.ibm.com
Date: Wed,  1 Sep 2010 15:23:23 -0300

> This change just add the IBM eHEA 10Gb network drivers as supported.
> 
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index c36f5d7..9f40d29 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2201,6 +2201,12 @@  L:	linux-rdma@vger.kernel.org
 S:	Supported
 F:	drivers/infiniband/hw/ehca/
 
+EHEA (IBM pSeries eHEA 10Gb ethernet adapter) DRIVER
+M:	Breno Leitao <leitao@linux.vnet.ibm.com>
+L:	netdev@vger.kernel.org
+S:	Maintained
+F:	drivers/net/ehea/
+
 EMBEDDED LINUX
 M:	Paul Gortmaker <paul.gortmaker@windriver.com>
 M:	Matt Mackall <mpm@selenic.com>