From patchwork Fri Jun 18 20:05:32 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dimitris Michailidis X-Patchwork-Id: 56217 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF6FC1007D5 for ; Sat, 19 Jun 2010 06:12:41 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933571Ab0FRUMb (ORCPT ); Fri, 18 Jun 2010 16:12:31 -0400 Received: from stargate.chelsio.com ([67.207.112.58]:14796 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933374Ab0FRUMU (ORCPT ); Fri, 18 Jun 2010 16:12:20 -0400 Received: from maui.asicdesigners.com (maui.asicdesigners.com [10.192.180.15]) by stargate.chelsio.com (8.13.1/8.13.1) with SMTP id o5IKCJQO018644 for ; Fri, 18 Jun 2010 13:12:21 -0700 Received: from darkside.asicdesigners.com ([10.192.161.150]) by maui.asicdesigners.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 18 Jun 2010 13:05:36 -0700 Received: from darkside.asicdesigners.com (localhost.localdomain [127.0.0.1]) by darkside.asicdesigners.com (8.13.4/8.13.4) with ESMTP id o5IK5a4Q014035; Fri, 18 Jun 2010 13:05:36 -0700 Received: (from dm@localhost) by darkside.asicdesigners.com (8.13.4/8.13.4/Submit) id o5IK5aQ2014034; Fri, 18 Jun 2010 13:05:36 -0700 From: Dimitris Michailidis To: netdev@vger.kernel.org Cc: Dimitris Michailidis Subject: [PATCH net-next 6/9] cxgb4: propagate link initialization errors to .ndo_open's callers Date: Fri, 18 Jun 2010 13:05:32 -0700 Message-Id: <1276891535-13967-7-git-send-email-dm@chelsio.com> X-Mailer: git-send-email 1.5.4 In-Reply-To: <1276891535-13967-6-git-send-email-dm@chelsio.com> References: <1276891535-13967-1-git-send-email-dm@chelsio.com> <1276891535-13967-2-git-send-email-dm@chelsio.com> <1276891535-13967-3-git-send-email-dm@chelsio.com> <1276891535-13967-4-git-send-email-dm@chelsio.com> <1276891535-13967-5-git-send-email-dm@chelsio.com> <1276891535-13967-6-git-send-email-dm@chelsio.com> X-OriginalArrivalTime: 18 Jun 2010 20:05:37.0044 (UTC) FILETIME=[9E10F540:01CB0F21] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Dimitris Michailidis --- drivers/net/cxgb4/cxgb4_main.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c index 6bfe7d6..eb1492f 100644 --- a/drivers/net/cxgb4/cxgb4_main.c +++ b/drivers/net/cxgb4/cxgb4_main.c @@ -2512,9 +2512,10 @@ static int cxgb_open(struct net_device *dev) } dev->real_num_tx_queues = pi->nqsets; - link_start(dev); - netif_tx_start_all_queues(dev); - return 0; + err = link_start(dev); + if (!err) + netif_tx_start_all_queues(dev); + return err; } static int cxgb_close(struct net_device *dev)