From patchwork Tue May 18 05:49:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 52833 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 69E25B7D8D for ; Tue, 18 May 2010 15:50:06 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756131Ab0ERFt7 (ORCPT ); Tue, 18 May 2010 01:49:59 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:34835 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755826Ab0ERFt6 (ORCPT ); Tue, 18 May 2010 01:49:58 -0400 Received: by wwi17 with SMTP id 17so211399wwi.19 for ; Mon, 17 May 2010 22:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=4mjZUYJ0JuzJFR+0T5OhAJVn5GLIQETCAIky7yb9AKI=; b=cP1WnU/ggd0nbPWGNk3VXB0qMmt6ot6Egt74KukV9RHCab/XR/nvlrseS/IAYSf1ql CDMM9SWAKAaNYhZm0YdGfqaejnPaBZWlOVpY+SDSwzLn1VXniKHaiFLiI0bKyOi5ndAH r6AtWWSWf7YPDgpUwGvqIu07Wxc71uLV9bOis= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=UL5acsw7qg5PVxgJHAkauGU41Nb5jiFdL7mkRLXOoty2jFuS1WZUmp4KEItszv8cHm VFD2KZnGwYl6VHWCsFjqxzy3FpXTAECozgarpIiOD79zA3iCDufFaw/0MaS8flBfHJK5 2LRjlcI4sTZeOACNTrftK/vV6p80NLrYPVsHY= Received: by 10.227.155.140 with SMTP id s12mr5742133wbw.145.1274161796618; Mon, 17 May 2010 22:49:56 -0700 (PDT) Received: from [127.0.0.1] ([85.17.35.125]) by mx.google.com with ESMTPS id u36sm13086862wbv.18.2010.05.17.22.49.55 (version=SSLv3 cipher=RC4-MD5); Mon, 17 May 2010 22:49:56 -0700 (PDT) Subject: Re: kernel panic From: Eric Dumazet To: senthilkumaar2021 Cc: "Justin P. Mattock" , netdev , Bart De Schuymer In-Reply-To: <4BF222C8.6000200@gmail.com> References: <4BF21646.60008@gmail.com> <4BF21BD3.60901@gmail.com> <4BF21DAD.6050609@gmail.com> <1274159136.2567.24.camel@edumazet-laptop> <4BF222C8.6000200@gmail.com> Date: Tue, 18 May 2010 07:49:54 +0200 Message-ID: <1274161794.2567.33.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le mardi 18 mai 2010 à 10:46 +0530, senthilkumaar2021 a écrit : > Hi > > thanks fro the reply > > i was able to capture only part of the message > > Machine was running squid 2.7stable6 with tproxy4 > in bridge mode on Linux kernel 2.6.28.5 and the server had > kernel panic for every 10 to 12 hours. The logged error: > > [] bnx2_poll_work+0xea0/0xfb9 [bnx2] > [] enqueue_task+0x50/0x5b > [] getnstimeofday+0x53/0xb2 > [] bnx2_poll+0xd1/0x1ae [bnx2] > [] net_rx_action+0x9d/0x158 > [] __do_softirq+0x7a/0x13d > [] bnx2_msi+0x40/0x47 [bnx2] > [] call_softirq+0x1c/0x28 > [] do_softirq+0x2c/0x68 > [] irq_exit+0x3f/0x85 > [] do_IRQ+0x14a/0x16b > [] ret_from_intr+0x0/0xa > <0> [] acpi_idle_enter_bm+0x2a3/0x30e > [] acpi_idle_enter_bm+0x299/0x30e > [] rcu_needs_cpu+0x35/0x44 > [] cpuidle_idle_call+0x7f/0xbe > [] cpu_idle+0x4a/0x6d > Code: 5e 5b 5d 31 c0 c3 41 55 41 54 55 53 48 89 fb 48 83 ec 68 4c 8b > a7 98 00 00 > 00 4c 8b 6f 20 48 8b b7 d0 00 00 00 8b 8f bc 00 00 00 <41> f6 44 24 > 18 01 74 12 > 8a 47 7d 83 e0 f8 83 c8 03 88 47 7d 41 > RIP [] br_nf_pre_routing_finish+0x25/0x2af [bridge] > RSP > CR2: 0000000000000018 > Kernel panic - not syncing: Fatal exception in interrupt > > The kernel panic occurred in CentOS as well as Fedora 8 64 bit. > > When we checked this with squid community, they replied it as the > problem of the Network Card. When the NIC was changed to Intel from > Broadcom, RAM replaced with new sets and kernel updated to 2.6.30.5, the > find it attached). This happens once in two days. We have been trying to > resolve this for over 3 weeks now but in vain, any help on this is much > appreciated. > > hardware detail_ > > CPU : 3.0 GHz > RAM : 4 GB RAM > HDD : 4 x 150 GB > > OS : Fedora 8 64 bit > FS : ReiserFS > Max request rate : 400 per second You could try to adapt commit e94c67436e Maybe its same problem... commit e94c67436efa22af7d8b7d19c885863246042543 Author: Bart De Schuymer Date: Thu May 13 14:55:34 2010 +0200 netfilter: bridge-netfilter: fix crash in br_nf_forward_finish() [ 4593.956206] BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 [ 4593.956219] IP: [] br_nf_forward_finish+0x154/0x170 [bridge] [ 4593.956232] PGD 195ece067 PUD 1ba005067 PMD 0 [ 4593.956241] Oops: 0000 [#1] SMP [ 4593.956248] last sysfs file: /sys/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:08/ATK0110:00/hwmon/hwmon0/temp2_label [ 4593.956253] CPU 3 ... [ 4593.956380] Pid: 29512, comm: kvm Not tainted 2.6.34-rc7-net #195 P6T DELUXE/System Product Name [ 4593.956384] RIP: 0010:[] [] br_nf_forward_finish+0x154/0x170 [bridge] [ 4593.956395] RSP: 0018:ffff880001e63b78 EFLAGS: 00010246 [ 4593.956399] RAX: 0000000000000608 RBX: ffff880057181700 RCX: ffff8801b813d000 [ 4593.956402] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff880057181700 [ 4593.956406] RBP: ffff880001e63ba8 R08: ffff8801b9d97000 R09: ffffffffa0335650 [ 4593.956410] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8801b813d000 [ 4593.956413] R13: ffffffff81ab3940 R14: ffff880057181700 R15: 0000000000000002 [ 4593.956418] FS: 00007fc40d380710(0000) GS:ffff880001e60000(0000) knlGS:0000000000000000 [ 4593.956422] CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b [ 4593.956426] CR2: 0000000000000018 CR3: 00000001ba1d7000 CR4: 00000000000026e0 [ 4593.956429] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 4593.956433] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 4593.956437] Process kvm (pid: 29512, threadinfo ffff8801ba566000, task ffff8801b8003870) [ 4593.956441] Stack: [ 4593.956443] 0000000100000020 ffff880001e63ba0 ffff880001e63ba0 ffff880057181700 [ 4593.956451] <0> ffffffffa0335650 ffffffff81ab3940 ffff880001e63bd8 ffffffffa03350e6 [ 4593.956462] <0> ffff880001e63c40 000000000000024d ffff880057181700 0000000080000000 [ 4593.956474] Call Trace: [ 4593.956478] [ 4593.956488] [] ? br_nf_forward_finish+0x0/0x170 [bridge] [ 4593.956496] [] NF_HOOK_THRESH+0x56/0x60 [bridge] [ 4593.956504] [] br_nf_forward_arp+0x112/0x120 [bridge] [ 4593.956511] [] nf_iterate+0x64/0xa0 [ 4593.956519] [] ? br_forward_finish+0x0/0x60 [bridge] [ 4593.956524] [] nf_hook_slow+0x6c/0x100 [ 4593.956531] [] ? br_forward_finish+0x0/0x60 [bridge] [ 4593.956538] [] ? __br_forward+0x0/0xc0 [bridge] [ 4593.956545] [] __br_forward+0x6d/0xc0 [bridge] [ 4593.956550] [] ? skb_clone+0x3e/0x70 [ 4593.956557] [] deliver_clone+0x32/0x60 [bridge] [ 4593.956564] [] br_flood+0xa6/0xe0 [bridge] [ 4593.956571] [] ? __br_forward+0x0/0xc0 [bridge] Don't call nf_bridge_update_protocol() for ARP traffic as skb->nf_bridge isn't used in the ARP case. Reported-by: Stephen Hemminger Signed-off-by: Bart De Schuymer Signed-off-by: Patrick McHardy --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index 93f80fe..4442099 100644 --- a/net/bridge/br_netfilter.c +++ b/net/bridge/br_netfilter.c @@ -643,10 +643,10 @@ static int br_nf_forward_finish(struct sk_buff *skb) skb->pkt_type = PACKET_OTHERHOST; nf_bridge->mask ^= BRNF_PKT_TYPE; } + nf_bridge_update_protocol(skb); } else { in = *((struct net_device **)(skb->cb)); } - nf_bridge_update_protocol(skb); nf_bridge_push_encap_header(skb); NF_HOOK_THRESH(NFPROTO_BRIDGE, NF_BR_FORWARD, skb, in,