From patchwork Wed Dec 9 13:40:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 40723 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4F908B6EDF for ; Thu, 10 Dec 2009 00:40:19 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756011AbZLINkE (ORCPT ); Wed, 9 Dec 2009 08:40:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755901AbZLINkB (ORCPT ); Wed, 9 Dec 2009 08:40:01 -0500 Received: from smtp.gentoo.org ([140.211.166.183]:33778 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755894AbZLINkA (ORCPT ); Wed, 9 Dec 2009 08:40:00 -0500 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 604AF64DB5; Wed, 9 Dec 2009 13:40:07 +0000 (UTC) From: Mike Frysinger To: netdev@vger.kernel.org, "David S. Miller" , Nicolas Pitre Cc: linux-kernel@vger.kernel.org Subject: [PATCH] smc91x: fix unused flags warnings on UP systems Date: Wed, 9 Dec 2009 08:40:04 -0500 Message-Id: <1260366004-27366-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.6.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Local flags variables will be declared whenever these functions get used, but obviously on UP systems the flags parameter won't be touched. So add some dummy ops that get optimized away anyways to satisfy gcc's warnings. Signed-off-by: Mike Frysinger Acked-by: Nicolas Pitre --- drivers/net/smc91x.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index ae4983a..b0c92b6 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -534,9 +534,9 @@ static inline void smc_rcv(struct net_device *dev) #define smc_special_lock(lock, flags) spin_lock_irqsave(lock, flags) #define smc_special_unlock(lock, flags) spin_unlock_irqrestore(lock, flags) #else -#define smc_special_trylock(lock, flags) (1) -#define smc_special_lock(lock, flags) do { } while (0) -#define smc_special_unlock(lock, flags) do { } while (0) +#define smc_special_trylock(lock, flags) (flags == flags) +#define smc_special_lock(lock, flags) do { flags = 0; } while (0) +#define smc_special_unlock(lock, flags) do { flags = 0; } while (0) #endif /*