From patchwork Wed Aug 12 14:58:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Rosenboom X-Patchwork-Id: 31196 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id C58DAB7080 for ; Thu, 13 Aug 2009 01:45:47 +1000 (EST) Received: by ozlabs.org (Postfix) id B6327DDD0B; Thu, 13 Aug 2009 01:45:47 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 381F5DDD04 for ; Thu, 13 Aug 2009 01:45:47 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752564AbZHLPpg (ORCPT ); Wed, 12 Aug 2009 11:45:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752555AbZHLPpg (ORCPT ); Wed, 12 Aug 2009 11:45:36 -0400 Received: from leia.mcbone.net ([194.97.104.42]:55372 "EHLO leia.mcbone.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbZHLPpf (ORCPT ); Wed, 12 Aug 2009 11:45:35 -0400 Received: from fnki-ws00028.freenet-ag.de ([194.97.6.48]) by leia.mcbone.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MbFHe-000806-MG; Wed, 12 Aug 2009 14:58:34 +0000 Subject: [PATCH] ipv6: Log the explicit address that triggered DAD failure From: Jens Rosenboom To: Linux Network Developers Cc: David Miller Date: Wed, 12 Aug 2009 16:58:27 +0200 Message-Id: <1250089107.6641.36.camel@fnki-nb00130> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If an interface has multiple addresses, the current message for DAD failure isn't really helpful, so this patch adds the address itself to the printk. Signed-off-by: Jens Rosenboom --- struct in6_addr addr; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 43b3c9f..01a4b25 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1403,8 +1403,8 @@ void addrconf_dad_failure(struct inet6_ifaddr *ifp) struct inet6_dev *idev = ifp->idev; if (net_ratelimit()) - printk(KERN_INFO "%s: IPv6 duplicate address detected!\n", - ifp->idev->dev->name); + printk(KERN_INFO "%s: IPv6 duplicate address %pI6 detected!\n", + ifp->idev->dev->name, &ifp->addr); if (idev->cnf.accept_dad > 1 && !idev->cnf.disable_ipv6) {