From patchwork Thu Jun 18 14:16:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 28867 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 5D69FB72AA for ; Fri, 19 Jun 2009 00:17:26 +1000 (EST) Received: by ozlabs.org (Postfix) id 4D016DDDA1; Fri, 19 Jun 2009 00:17:26 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id C640CDDD1B for ; Fri, 19 Jun 2009 00:17:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761616AbZFRORL (ORCPT ); Thu, 18 Jun 2009 10:17:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758598AbZFRORL (ORCPT ); Thu, 18 Jun 2009 10:17:11 -0400 Received: from mail-fx0-f212.google.com ([209.85.220.212]:64086 "EHLO mail-fx0-f212.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755684AbZFRORF (ORCPT ); Thu, 18 Jun 2009 10:17:05 -0400 Received: by fxm8 with SMTP id 8so1082401fxm.37 for ; Thu, 18 Jun 2009 07:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=HftqswbnHDqPJlGHBnQtVefRRFRqTgrfF7XULGhjrM0=; b=Z/iU2DuRS++Ehc4W93dRkCZa0+Sr2DcC09QXhwO3kh6kGaWothuJM1oBL/ZD9wtqZ1 TWTsrzCjM/M8vw0sFYeZstGgqZYdOW9ECah7Hi9UMjWCdzs9bIstgSAG+dfTDSwkCHCI 7Euh5a8AThFxBcqErjQtHKnWLRRx1YndHhEX8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=DKeZMr7aK2bfKo63hXkHu1fiQaVJCLNzU4k9FgsaYseITrkINHjOlWs8uyF0BB94p/ vHcplo6codfMbEjYf1vWN5kxnmkkLhkZvHRg3CN4+k+2dDK2HDAgCkc40mgFgdITb/+N 6xpVLAPxhb85WUyXpV6ciUGpyY6UiX6dNP0HQ= Received: by 10.216.8.65 with SMTP id 43mr431044weq.168.1245334626824; Thu, 18 Jun 2009 07:17:06 -0700 (PDT) Received: from localhost.localdomain (iap-pxy-mow1.siemens.ru [212.248.25.26]) by mx.google.com with ESMTPS id g11sm4832656gve.16.2009.06.18.07.17.05 (version=SSLv3 cipher=RC4-MD5); Thu, 18 Jun 2009 07:17:06 -0700 (PDT) From: Dmitry Eremin-Solenikov To: "David S. Miller" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slapin@ossfans.org Subject: [PATCH 1/2] ieee802154: use standard routine for printing dumps Date: Thu, 18 Jun 2009 18:16:46 +0400 Message-Id: <1245334607-16046-2-git-send-email-dbaryshkov@gmail.com> X-Mailer: git-send-email 1.6.3.1 In-Reply-To: <1245334607-16046-1-git-send-email-dbaryshkov@gmail.com> References: <1245334607-16046-1-git-send-email-dbaryshkov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use print_hex_dump_bytes instead of self-written dumping function for outputting packet dumps. Signed-off-by: Dmitry Eremin-Solenikov --- net/ieee802154/af_ieee802154.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/net/ieee802154/af_ieee802154.c b/net/ieee802154/af_ieee802154.c index 882a927..3bb6bdb 100644 --- a/net/ieee802154/af_ieee802154.c +++ b/net/ieee802154/af_ieee802154.c @@ -39,14 +39,6 @@ #include "af802154.h" -#define DBG_DUMP(data, len) { \ - int i; \ - pr_debug("function: %s: data: len %d:\n", __func__, len); \ - for (i = 0; i < len; i++) {\ - pr_debug("%02x: %02x\n", i, (data)[i]); \ - } \ -} - /* * Utility function for families */ @@ -302,10 +294,12 @@ static struct net_proto_family ieee802154_family_ops = { static int ieee802154_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt, struct net_device *orig_dev) { - DBG_DUMP(skb->data, skb->len); if (!netif_running(dev)) return -ENODEV; pr_debug("got frame, type %d, dev %p\n", dev->type, dev); +#ifdef DEBUG + print_hex_dump_bytes("ieee802154_rcv ", DUMP_PREFIX_NONE, skb->data, skb->len); +#endif if (!net_eq(dev_net(dev), &init_net)) goto drop;