From patchwork Wed Jun 17 11:28:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chaithrika@ti.com X-Patchwork-Id: 28786 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 50BC7B73AA for ; Wed, 17 Jun 2009 22:10:57 +1000 (EST) Received: by ozlabs.org (Postfix) id 44332DDDB2; Wed, 17 Jun 2009 22:10:57 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CC3FEDDDA2 for ; Wed, 17 Jun 2009 22:10:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760400AbZFQMKp (ORCPT ); Wed, 17 Jun 2009 08:10:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758801AbZFQMKo (ORCPT ); Wed, 17 Jun 2009 08:10:44 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:39263 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758274AbZFQMKo (ORCPT ); Wed, 17 Jun 2009 08:10:44 -0400 Received: from dflp53.itg.ti.com ([128.247.5.6]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id n5HCAgKk009862 for ; Wed, 17 Jun 2009 07:10:47 -0500 Received: from tidmzi-ftp.india.ext.ti.com (localhost [127.0.0.1]) by dflp53.itg.ti.com (8.13.8/8.13.8) with SMTP id n5HCAe1B029209; Wed, 17 Jun 2009 07:10:41 -0500 (CDT) Received: from symphonyindia.ti.com (symphony-ftp [192.168.247.11]) by tidmzi-ftp.india.ext.ti.com (Postfix) with SMTP id 4B4AA3886B; Wed, 17 Jun 2009 17:37:59 +0530 (IST) Received: from localhost.localdomain ([192.168.247.76]) by symphonyindia.ti.com (8.12.10/8.12.10) with ESMTP id n5HC1N40002566; Wed, 17 Jun 2009 17:31:23 +0530 From: Chaithrika U S To: netdev@vger.kernel.org Cc: davinci-linux-open-source@linux.davincidsp.com, Chaithrika U S Subject: [PATCH] TI DaVinci EMAC : Fix rmmod error Date: Wed, 17 Jun 2009 07:28:54 -0400 Message-Id: <1245238134-23512-1-git-send-email-chaithrika@ti.com> X-Mailer: git-send-email 1.5.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org clk_disable was called twice in the remove function. Correct this so that the driver module unloads without error. Signed-off-by: Chaithrika U S Signed-off-by: Kevin Hilman --- Applies to Linus' kernel tree drivers/net/davinci_emac.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 0e9b9f9..2df8fb0 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -2767,7 +2767,6 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev) dev_notice(&ndev->dev, "DaVinci EMAC: davinci_emac_remove()\n"); - clk_disable(emac_clk); platform_set_drvdata(pdev, NULL); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mdiobus_unregister(priv->mii_bus);