From patchwork Mon Jun 1 11:18:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 27901 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id D65F4B7063 for ; Mon, 1 Jun 2009 21:18:16 +1000 (EST) Received: by ozlabs.org (Postfix) id C8D58DDDA1; Mon, 1 Jun 2009 21:18:16 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 65374DDD1B for ; Mon, 1 Jun 2009 21:18:16 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755408AbZFALRp (ORCPT ); Mon, 1 Jun 2009 07:17:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754712AbZFALRp (ORCPT ); Mon, 1 Jun 2009 07:17:45 -0400 Received: from smtp.nokia.com ([192.100.122.233]:52400 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754635AbZFALRp (ORCPT ); Mon, 1 Jun 2009 07:17:45 -0400 Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx06.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n51BHFR3017582 for ; Mon, 1 Jun 2009 14:17:39 +0300 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 1 Jun 2009 14:17:38 +0300 Received: from mgw-sa02.ext.nokia.com ([147.243.1.48]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Mon, 1 Jun 2009 14:17:38 +0300 Received: from localhost.localdomain (esdhcp037217.research.nokia.com [172.21.37.217]) by mgw-sa02.ext.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n51BHbXt003855 for ; Mon, 1 Jun 2009 14:17:37 +0300 From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= To: netdev@vger.kernel.org Subject: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback Date: Mon, 1 Jun 2009 14:18:55 +0300 Message-Id: <1243855137-20149-1-git-send-email-remi.denis-courmont@nokia.com> X-Mailer: git-send-email 1.6.0.4 MIME-Version: 1.0 X-OriginalArrivalTime: 01 Jun 2009 11:17:38.0059 (UTC) FILETIME=[921EF5B0:01C9E2AA] X-Nokia-AV: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rémi Denis-Courmont Network device TX is never run in IRQ context, and skb is freed outside of the IRQ-disabling spin lock. So checking for IRQ was a waste of time here. Signed-off-by: Rémi Denis-Courmont Signed-off-by: Felipe Balbi --- drivers/usb/gadget/f_phonet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c index c1abeb8..54451ee 100644 --- a/drivers/usb/gadget/f_phonet.c +++ b/drivers/usb/gadget/f_phonet.c @@ -255,7 +255,7 @@ out_unlock: spin_unlock_irqrestore(&port->lock, flags); out: if (unlikely(skb)) { - dev_kfree_skb_any(skb); + dev_kfree_skb(skb); dev->stats.tx_dropped++; } return 0;