From patchwork Fri May 15 12:52:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hlusiak X-Patchwork-Id: 27254 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 6CE4EB6F44 for ; Fri, 15 May 2009 22:52:24 +1000 (EST) Received: by ozlabs.org (Postfix) id 5EA42DE107; Fri, 15 May 2009 22:52:24 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id EFA33DE106 for ; Fri, 15 May 2009 22:52:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbZEOMwT (ORCPT ); Fri, 15 May 2009 08:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756032AbZEOMwR (ORCPT ); Fri, 15 May 2009 08:52:17 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:62231 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755515AbZEOMwO (ORCPT ); Fri, 15 May 2009 08:52:14 -0400 Received: from localhost.localdomain (g228068143.adsl.alicedsl.de [92.228.68.143]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1M4wta45QM-0001CF; Fri, 15 May 2009 14:52:15 +0200 From: Sascha Hlusiak To: netdev@vger.kernel.org Cc: Sascha Hlusiak Subject: [PATCH 4/5] addrconf: refuse isatap eui64 for INADDR_ANY Date: Fri, 15 May 2009 14:52:50 +0200 Message-Id: <1242391971-32583-4-git-send-email-contact@saschahlusiak.de> X-Mailer: git-send-email 1.6.3 In-Reply-To: <1242391971-32583-3-git-send-email-contact@saschahlusiak.de> References: <1242391971-32583-1-git-send-email-contact@saschahlusiak.de> <1242391971-32583-2-git-send-email-contact@saschahlusiak.de> <1242391971-32583-3-git-send-email-contact@saschahlusiak.de> X-Provags-ID: V01U2FsdGVkX19YkipiRayIdrtOtD+lEW0PTu2sHjeWRFOrTda ofcbUQ3BXWZekldQ8P84HTXEsOceeAtHRNFFzvnYx5OEvAPQz1 txau3Gd1NkoO23Yyld9gZNNxBHkqwPG Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A tunnel with no local ipv4 endpoint would otherwise use the ISATAP linklocal address fe80::5efe:0:0, which is invalid. Rather not add a linklocal address at all. --- net/ipv6/addrconf.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index a8218bc..550fb79 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1520,6 +1520,8 @@ static int addrconf_ifid_infiniband(u8 *eui, struct net_device *dev) int __ipv6_isatap_ifid(u8 *eui, __be32 addr) { + if (addr == 0) + return -1; eui[0] = (ipv4_is_zeronet(addr) || ipv4_is_private_10(addr) || ipv4_is_loopback(addr) || ipv4_is_linklocal_169(addr) || ipv4_is_private_172(addr) || ipv4_is_test_192(addr) ||