From patchwork Mon Jan 12 08:13:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 17887 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 10614DDFE2 for ; Mon, 12 Jan 2009 19:14:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbZALIOI (ORCPT ); Mon, 12 Jan 2009 03:14:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751352AbZALIOH (ORCPT ); Mon, 12 Jan 2009 03:14:07 -0500 Received: from casper.infradead.org ([85.118.1.10]:41125 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbZALIOF (ORCPT ); Mon, 12 Jan 2009 03:14:05 -0500 Received: from macbook.infradead.org ([2001:8b0:10b:1:216:eaff:fe05:bbb8]) by casper.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1LMHvs-0005SG-M7; Mon, 12 Jan 2009 08:14:00 +0000 Subject: Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok) From: David Woodhouse To: Valdis.Kletnieks@vt.edu Cc: David Miller , alessandro.suardi@gmail.com, jaswinderlinux@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <4407.1231719036@turing-police.cc.vt.edu> References: <5a4c581d0901090930j5d4760b0x730b5609fa2b5614@mail.gmail.com> <20090109.140422.60087297.davem@davemloft.net> <43805.1231672258@turing-police.cc.vt.edu> <20090111.040842.86784676.davem@davemloft.net> <1231676698.25018.147.camel@macbook.infradead.org> <1231678799.25018.195.camel@macbook.infradead.org> <4407.1231719036@turing-police.cc.vt.edu> Date: Mon, 12 Jan 2009 08:13:59 +0000 Message-Id: <1231748039.25018.1277.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-2.fc10) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2009-01-11 at 19:10 -0500, Valdis.Kletnieks@vt.edu wrote: > So it looks like the patch is failing to finish initialization of the card. > Damned if *I* can see what's breaking it, the conversion to use a helper > function tg3_request_firmware seems sane enough.... Ahem... --- drivers/net/tg3.c.stupiddwmw2 2009-01-12 08:13:05.000000000 +0000 +++ drivers/net/tg3.c 2009-01-12 08:13:09.000000000 +0000 @@ -13151,7 +13151,7 @@ static int __devinit tg3_init_one(struct try again in tg3_open(). So if you have the driver built into the kernel, you can still get the firmware loaded after userspace is running, when the device comes up. */ - if (err != -ENOENT) + if (err && err != -ENOENT) goto err_out_fw; }