From patchwork Sun Jan 11 16:53:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 17822 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 25546DDFEB for ; Mon, 12 Jan 2009 03:53:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbZAKQxf (ORCPT ); Sun, 11 Jan 2009 11:53:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752805AbZAKQxe (ORCPT ); Sun, 11 Jan 2009 11:53:34 -0500 Received: from casper.infradead.org ([85.118.1.10]:48168 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbZAKQxd (ORCPT ); Sun, 11 Jan 2009 11:53:33 -0500 Received: from macbook.infradead.org ([2001:8b0:10b:1:216:eaff:fe05:bbb8]) by casper.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1LM3Z0-00025P-Ua; Sun, 11 Jan 2009 16:53:28 +0000 Subject: Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok) From: David Woodhouse To: Alessandro Suardi Cc: David Miller , Valdis.Kletnieks@vt.edu, jaswinderlinux@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <5a4c581d0901110842i5520cea1uff89d5772d0f3b6e@mail.gmail.com> References: <5a4c581d0901090930j5d4760b0x730b5609fa2b5614@mail.gmail.com> <20090109.140422.60087297.davem@davemloft.net> <43805.1231672258@turing-police.cc.vt.edu> <20090111.040842.86784676.davem@davemloft.net> <1231676698.25018.147.camel@macbook.infradead.org> <1231678799.25018.195.camel@macbook.infradead.org> <5a4c581d0901110842i5520cea1uff89d5772d0f3b6e@mail.gmail.com> Date: Sun, 11 Jan 2009 16:53:09 +0000 Message-Id: <1231692789.25018.415.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-2.fc10) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2009-01-11 at 17:42 +0100, Alessandro Suardi wrote: > Patches cleanly but doesn't build in 2.6.29-rc1: Pants; sorry, I omitted this bit... diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h index ae5da60..508def3 100644 --- a/drivers/net/tg3.h +++ b/drivers/net/tg3.h @@ -2764,6 +2764,7 @@ struct tg3 { struct ethtool_coalesce coal; /* firmware info */ + const char *fw_needed; const struct firmware *fw; u32 fw_len; /* includes BSS */ };