| Message ID | 1231692789.25018.415.camel@macbook.infradead.org |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Jan 11, 2009 at 5:53 PM, David Woodhouse <dwmw2@infradead.org> wrote: > On Sun, 2009-01-11 at 17:42 +0100, Alessandro Suardi wrote: >> Patches cleanly but doesn't build in 2.6.29-rc1: > > Pants; sorry, I omitted this bit... > > diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h > index ae5da60..508def3 100644 > --- a/drivers/net/tg3.h > +++ b/drivers/net/tg3.h > @@ -2764,6 +2764,7 @@ struct tg3 { > struct ethtool_coalesce coal; > > /* firmware info */ > + const char *fw_needed; > const struct firmware *fw; > u32 fw_len; /* includes BSS */ > }; > This one works, thank you. However, with the combination of in-kernel tg3 and CONFIG_IN_KERNEL_FIRMWARE=n there is at least a 30" delay during boot while waiting for the firmware request (which will fail). Such wait didn't use to be there, and stuff worked. Could the wait be removed, to behave as it used to - as well ? Thanks again, ciao, --alessandro "Sun keeps rising in the west / I keep on waking fully confused" (The Replacements, "Within Your Reach") -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2009-01-11 at 20:24 +0100, Alessandro Suardi wrote: > However, with the combination of in-kernel tg3 and > CONFIG_IN_KERNEL_FIRMWARE=n there is at least a 30" delay > during boot while waiting for the firmware request (which will fail). Hm, ideally it should fail fast if the root file system isn't yet mounted. I thought we'd seen and fixed a 'long delay' problem already. I'll take another look.
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h index ae5da60..508def3 100644 --- a/drivers/net/tg3.h +++ b/drivers/net/tg3.h @@ -2764,6 +2764,7 @@ struct tg3 { struct ethtool_coalesce coal; /* firmware info */ + const char *fw_needed; const struct firmware *fw; u32 fw_len; /* includes BSS */ };
On Sun, 2009-01-11 at 17:42 +0100, Alessandro Suardi wrote: > Patches cleanly but doesn't build in 2.6.29-rc1: Pants; sorry, I omitted this bit...