| Message ID | 0dc76b70-b578-e698-1b3b-8b0d6cacca06@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pXb6/L3Y"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40QdsK50dQz9s1d for <patchwork-incoming-netdev@ozlabs.org>; Wed, 18 Apr 2018 07:38:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399AbeDQViK (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Tue, 17 Apr 2018 17:38:10 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:42261 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbeDQVgg (ORCPT <rfc822;netdev@vger.kernel.org>); Tue, 17 Apr 2018 17:36:36 -0400 Received: by mail-wr0-f194.google.com with SMTP id s18so39359463wrg.9 for <netdev@vger.kernel.org>; Tue, 17 Apr 2018 14:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Q6gARWwjeQ+Paackza9mAMCuDMI+khnmzqstT5F/BHc=; b=pXb6/L3Y1PFfxwrGLfJNjt54032i07WhqYLUv7Irxu0Yp9wHnj905ANwKlQ/du+Wj4 gUs8ZqYbBTI6t+eh3/ABUWVP6Mzi5VG5yaihKZqsqdusAR3SJBiXoGvEpy2H2PcF8ju5 Oc5vmOWhmgUEgi1NxVEvCmPqrIggbl205SdVw+GU3GsOZNJJ/PV1Rw/pAwPYgaWgp0yP 6tNgYysk4PINgTco3aRXeFX4lv87dQCAqYahYk/G1aISjPbCZsM5a/RlZX7dRs8IOCMM XB2CDzF5AIZQCVFe4/yRfSwV2JJEon2ev4oUuowm9H3ZrK+Zo9L6Fwlx5ZWlMxO6Ptbm 0jHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Q6gARWwjeQ+Paackza9mAMCuDMI+khnmzqstT5F/BHc=; b=RGE6ODvkhcX99CHGhi6tfNjHQ9vdaptusg6hXWK3mUl0cakcd2+2VYBWVLKnmoI7Nf Uvh4AzGgVIU7I/aNPQ6+0YrNXLy9CcuwowerZW9tGMMAHqyjM2WnF5f2Zd+mMcJtor0X 8sddNy3yVB+XHpH9WBknroipzMstOQo5pbduhfKLoaRbEaRSXOlBczKwJefT5l9c2tGp 4GXUYEr/x/uYC+qXmrkbdk5/PbId3X/+rYlR2qzsvzLCkoWJLkk/hqYeDR21oilvP+eo kaRY76JaqMYZpdvl2Yjm16QglgPjSATCo/2iPmwqUTOcCXGnuXVfm8qEPER+ewjiffLs +IWQ== X-Gm-Message-State: ALQs6tDTmTcyiDfaCiQ6H3zXcyh0NF37iUjVseD+xtWh19eMEp9fc1XT KwKQ9U+fbnhy90/VUtvZBbYYcw== X-Google-Smtp-Source: AIpwx48JsO8gmjq0J9uvp1G9hgEc4pz0JiUsCw4DF7QTq4VTTkZCKqxPf83uAjgD203qQqa7YIoy1g== X-Received: by 10.223.146.166 with SMTP id 35mr2566712wrn.132.1524000994935; Tue, 17 Apr 2018 14:36:34 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:3d00:f08f:8edb:1bd1:a1a? (p200300EA8BD43D00F08F8EDB1BD10A1A.dip0.t-ipconnect.de. [2003:ea:8bd4:3d00:f08f:8edb:1bd1:a1a]) by smtp.googlemail.com with ESMTPSA id a205sm11331742wmf.18.2018.04.17.14.36.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 14:36:34 -0700 (PDT) Subject: [PATCH net-next 03/19] r8169: use skb_copy_to_linear_data in rtl8169_try_rx_copy From: Heiner Kallweit <hkallweit1@gmail.com> To: David Miller <davem@davemloft.net>, Realtek linux nic maintainers <nic_swsd@realtek.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org> References: <4049e598-1b6c-bc3e-a905-178b76d7b161@gmail.com> Message-ID: <0dc76b70-b578-e698-1b3b-8b0d6cacca06@gmail.com> Date: Tue, 17 Apr 2018 23:19:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4049e598-1b6c-bc3e-a905-178b76d7b161@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
| Series |
r8169: series with further smaller improvements
|
expand
|
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 14f494a9..8c303617 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7359,7 +7359,7 @@ static struct sk_buff *rtl8169_try_rx_copy(void *data, prefetch(data); skb = napi_alloc_skb(&tp->napi, pkt_size); if (skb) - memcpy(skb->data, data, pkt_size); + skb_copy_to_linear_data(skb, data, pkt_size); dma_sync_single_for_device(d, addr, pkt_size, DMA_FROM_DEVICE); return skb;
Not a giant leap for mankind, but let's avoid the open-coded memcpy and use standard helper skb_copy_to_linear_data instead. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)