From patchwork Mon May 22 09:12:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 765289 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wWXzG5jSHz9s7p for ; Mon, 22 May 2017 19:14:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757877AbdEVJOD (ORCPT ); Mon, 22 May 2017 05:14:03 -0400 Received: from mout.web.de ([212.227.15.14]:60171 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757582AbdEVJOA (ORCPT ); Mon, 22 May 2017 05:14:00 -0400 Received: from [192.168.1.2] ([78.49.33.162]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MgfTT-1dZdrX26Q3-00NvsL; Mon, 22 May 2017 11:13:00 +0200 Subject: [PATCH 1/3] net: pktgen: Improve four size determinations From: SF Markus Elfring To: netdev@vger.kernel.org, Alexey Dobriyan , "David S. Miller" , Eric Dumazet , Florian Westphal , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , John Fastabend , Paolo Abeni , Willem de Bruijn Cc: LKML , kernel-janitors@vger.kernel.org References: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Message-ID: <08d6e27c-dcc3-5e24-7ec9-ba1587309658@users.sourceforge.net> Date: Mon, 22 May 2017 11:12:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <79472009-7764-bb92-5f29-60bb21793cec@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:jmXsCe8ddNo8urnafxDmKUd7hfRlEsv9YNyhS3aS75D37t2R/jK BbzwtTTJ86L0ZbwmmeE+2geFYM7m+p4fnq3tNvOlv0PqSd9ttE3+4n4La6KYr8I+wEPXHPE sjPHivTiuxdEa3YpyMyvjo3WkjFebmY3sSbJPYyFnOdKqS8ZSNUO69DkUPTSy2UVR8Iq0j8 J59phcJK7UsHRAP0VgDgg== X-UI-Out-Filterresults: notjunk:1; V01:K0:toVpcI+mGPc=:G4BWQaHCcCqut5PIN3vuAb S8pjXk6xRcDgH9oDKya6X0dKv9sFdTCkTcaiC7Z5fBpOdDxO0UP05CeJw0DUqP+tWZOHNgSOu aknQa7n30XZPHsZ/HoHI1jro6qsus4wj6D+KCfjbt6Y3+wxlFtaYT1lAx5ShWknrP2CEfUxlC NVuZASMeR4mwKn09NkHdsQrlfIS3VSLjVfZzUVPSIfD/Yl4soUSMld1Z6LNYoDWm4bzC8/NwV x1Rft/Rjsg0eGHk26oQDnb8BKlpopyTUXWPP/OC9r3zkg5r94eFl4TM19d/KU7j7DJOedJH92 BTfFetA7ltkyOIOgoSCLOVsjKtwO1t3bt/KSU/a0SQpxVN1YKOVTLQdbhwmP6p2PcYrEW1JIv NwtamfnKkVEwNoh1xp9naTTPvsxf/6UzYqud8aNv6TM3oc7vnN0hsnE6KdNx3JzODYUOoEKqh EBd3qE7d9dY3zEAYrWRGYXy5C92jtl7wPUlNEnXNXs1dTZs9yJQv7a9o3NXFmnf3XHBXTYBU7 UKYb4XYSJvC4Y8JJLx+Kdsgw53+MW0mtWD5eoDMNg+I4V66GKCy97odG4x/qypVs3zXlxrgxu d9DTu7F7j+Js8W2eNVKnM0kcgjPYWteNQzgjGk1r6Z5Owx2x9O64DRHrUEjTO2tvvQFygKg/n c5rom5PdRFklrIWdYnZNo7SnVG2thaOSZMFuFN4qqLpFFYtNaGteKLkuQWIGluG/5KEV8DhlQ FjCihxLCPMra5quOYVwufaaVVH4JK5GBMx46eI+dxN3rD1LQhUMqequAkQyFm9HJmtSOpJ0hk CKNV28W Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 10:34:11 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- net/core/pktgen.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 96947f5d41e4..c89f4ad21187 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2995,10 +2995,10 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev, skb_reset_mac_header(skb); skb_set_network_header(skb, skb->len); - iph = (struct ipv6hdr *) skb_put(skb, sizeof(struct ipv6hdr)); + iph = (struct ipv6hdr *)skb_put(skb, sizeof(*iph)); skb_set_transport_header(skb, skb->len); - udph = (struct udphdr *) skb_put(skb, sizeof(struct udphdr)); + udph = (struct udphdr *)skb_put(skb, sizeof(*udph)); skb_set_queue_mapping(skb, queue_map); skb->priority = pkt_dev->skb_priority; @@ -3678,5 +3678,5 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname) return -EBUSY; } - pkt_dev = kzalloc_node(sizeof(struct pktgen_dev), GFP_KERNEL, node); + pkt_dev = kzalloc_node(sizeof(*pkt_dev), GFP_KERNEL, node); if (!pkt_dev) @@ -3756,6 +3756,5 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn) struct proc_dir_entry *pe; struct task_struct *p; - t = kzalloc_node(sizeof(struct pktgen_thread), GFP_KERNEL, - cpu_to_node(cpu)); + t = kzalloc_node(sizeof(*t), GFP_KERNEL, cpu_to_node(cpu)); if (!t) {