From patchwork Sun Jan 15 18:19:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 715454 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v1l4f3Wrkz9srY for ; Mon, 16 Jan 2017 05:19:14 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kgC8MAtd"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdAOSTM (ORCPT ); Sun, 15 Jan 2017 13:19:12 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34212 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbdAOSTL (ORCPT ); Sun, 15 Jan 2017 13:19:11 -0500 Received: by mail-wm0-f66.google.com with SMTP id c85so25312748wmi.1 for ; Sun, 15 Jan 2017 10:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=qMo99O5Djmcn6JT0lWkzcqVP5p1spIEJuoYC47DFJsI=; b=kgC8MAtde7jBDosYOizVkMeIjpwM340eiefKJuALLdLqruLJ7kO7Mi1xgFnn5ygs4L /sL2kfbbRLfG0ouFrYWvqpZw+E2WcGWZjM9Oy2YPwoNZNbCGImWSpI/xqsOL8GQ8isHf DeU/pgpkR7bVwxc9rduGk2Dy+RAs69xI7elDiPyoF94/rzfCFLlha3KvmKzBLRNJrSaa CN3RxxH6BjQ/HCnXBe+ePzsIj6L0MyB7C2Frqwf6oivBgiMfiVcsip0JvhxWEFzMSvE0 BjqJukgim9dN7hs0vGAeEeMruVmQSqlBDUho6icGT7wBZEtAqQbFk1QJJnMQXDa9luYB cA9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=qMo99O5Djmcn6JT0lWkzcqVP5p1spIEJuoYC47DFJsI=; b=sXozRyyhNRgAksPQyPBqTi23pp0AOmigq+kyGJA+f5sGpRfZ4FeXnUbsXSsahp1v4e n/V5VOKSktVJkoG3cXTBWvwLjd9785LT3ESGHlIvw1p//B5nEYaduM9Y8xw65sf8WpCf qu9oouX4eUcGv1Nz8NGP4Gg+dWyGhHSqlB7oLZ4MjKBy0mD2VfzusnSSyQ1blBYZ1Vjf QWqqxVQUIFes5Ni8lO058TKJVhMzMIm1q14y359AnSmjhukgGPqTiaKiRNCLVpTrLRdp 3zP33zjutM4hvV8El/vWqpEjo1IY3iFLubClGzgMnnFtz8XZFa/2iVomWJ9VhR55iE/K 0SxQ== X-Gm-Message-State: AIkVDXJzpZv0geQS0GaQCN4NUi2kLJ6Pj8Q79e5aPYE/Dn8Tl6Dhu0vxeIUkC8AcUzgXtg== X-Received: by 10.223.160.172 with SMTP id m41mr19925883wrm.31.1484504345215; Sun, 15 Jan 2017 10:19:05 -0800 (PST) Received: from ?IPv6:2003:c6:ebc5:6c00:31c0:1cfd:d2e2:a729? (p200300C6EBC56C0031C01CFDD2E2A729.dip0.t-ipconnect.de. [2003:c6:ebc5:6c00:31c0:1cfd:d2e2:a729]) by smtp.googlemail.com with ESMTPSA id c9sm22213488wmi.16.2017.01.15.10.19.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jan 2017 10:19:04 -0800 (PST) From: Heiner Kallweit Subject: [PATCH] net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered To: "David S. Miller" Cc: "netdev@vger.kernel.org" Message-ID: <01b736a6-b9e9-05cf-0937-f6ac18ac8e3c@gmail.com> Date: Sun, 15 Jan 2017 19:19:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Don't use netdev_info and friends before the net_device is registered. This avoids ugly messages like "meson8b-dwmac c9410000.ethernet (unnamed net_device) (uninitialized): Enable RX Mitigation via HW Watchdog Timer" Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index d481c5f7..38e1fb75 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3305,9 +3305,9 @@ int stmmac_dvr_probe(struct device *device, (priv->plat->maxmtu >= ndev->min_mtu)) ndev->max_mtu = priv->plat->maxmtu; else if (priv->plat->maxmtu < ndev->min_mtu) - netdev_warn(priv->dev, - "%s: warning: maxmtu having invalid value (%d)\n", - __func__, priv->plat->maxmtu); + dev_warn(priv->device, + "%s: warning: maxmtu having invalid value (%d)\n", + __func__, priv->plat->maxmtu); if (flow_ctrl) priv->flow_ctrl = FLOW_AUTO; /* RX/TX pause on */ @@ -3319,7 +3319,8 @@ int stmmac_dvr_probe(struct device *device, */ if ((priv->synopsys_id >= DWMAC_CORE_3_50) && (!priv->plat->riwt_off)) { priv->use_riwt = 1; - netdev_info(priv->dev, "Enable RX Mitigation via HW Watchdog Timer\n"); + dev_info(priv->device, + "Enable RX Mitigation via HW Watchdog Timer\n"); } netif_napi_add(ndev, &priv->napi, stmmac_poll, 64); @@ -3345,17 +3346,17 @@ int stmmac_dvr_probe(struct device *device, /* MDIO bus Registration */ ret = stmmac_mdio_register(ndev); if (ret < 0) { - netdev_err(priv->dev, - "%s: MDIO bus (id: %d) registration failed", - __func__, priv->plat->bus_id); + dev_err(priv->device, + "%s: MDIO bus (id: %d) registration failed", + __func__, priv->plat->bus_id); goto error_mdio_register; } } ret = register_netdev(ndev); if (ret) { - netdev_err(priv->dev, "%s: ERROR %i registering the device\n", - __func__, ret); + dev_err(priv->device, "%s: ERROR %i registering the device\n", + __func__, ret); goto error_netdev_register; }