From patchwork Fri Oct 18 00:19:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 284379 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C5DAE2C00A7 for ; Fri, 18 Oct 2013 11:20:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755704Ab3JRAU0 (ORCPT ); Thu, 17 Oct 2013 20:20:26 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:12519 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755644Ab3JRAUY (ORCPT ); Thu, 17 Oct 2013 20:20:24 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUU00DA88WB5HB0@mailout3.samsung.com> for netdev@vger.kernel.org; Fri, 18 Oct 2013 09:19:23 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 48.AF.03881.B8E70625; Fri, 18 Oct 2013 09:19:23 +0900 (KST) X-AuditID: cbfee68d-b7eff6d000000f29-42-52607e8b0bc4 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 2B.1E.09055.B8E70625; Fri, 18 Oct 2013 09:19:23 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUU00EKF8WBTD50@mmp1.samsung.com>; Fri, 18 Oct 2013 09:19:23 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, 'Jingoo Han' , 'Don Fry' References: <00ae01cecb97$44d45770$ce7d0650$%han@samsung.com> In-reply-to: <00ae01cecb97$44d45770$ce7d0650$%han@samsung.com> Subject: [PATCH 04/15] net: pcnet32: remove unnecessary pci_set_drvdata() Date: Fri, 18 Oct 2013 09:19:23 +0900 Message-id: <00b301cecb97$b281bbf0$178533d0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7Ll0SOe8rR8TalTKCSgak/vu4b7AAAF4Bw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zA93uuoQggz1/9S3mnG9hsbi88BKr xbEFYhYvr09ldWDx2LLyJpNH3+X/LB59W1YxenzeJBfAEsVlk5Kak1mWWqRvl8CV0XBsDXtB H1vFscV7GRsY21m7GDk5JARMJM5ev8UIYYtJXLi3ng3EFhJYxigx66cMTM3mXyuh4osYJVo6 siHsX4wSjZurQWw2ATWJL18Os3cxcnCICOhKzL9uAhJmFkiSePP3AQtEua3E/Vt3mUFsTgE7 ifZnJ8FOEBbwlLizYBk7iM0ioCqx8EM3E4jNC1T/9PMHNghbUOLH5HssEDO1JDZva2KFsOUl Nq95ywyyVkJAXeLRX12QsIiAkcTMxTvZIEpEJPa9eAf0IRdQyTF2iWnzJzBC7BKQ+Db5EAtE r6zEpgPMEN9KShxccYNlAtD/SDbPQrJ5FpLNs5CsWMDIsopRNLUguaA4Kb3IUK84Mbe4NC9d Lzk/dxMjJBp7dzDePmB9iDEZaP1EZinR5HxgNOeVxBsamxlZmJqYGhuZW5qRJqwkzqvWYh0o JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgbE7rp7jxwLFaXvizWeJXvtdc/G9LbNFpb1fftDp BQK3z3x3+cBwMH21QY1165zzq12nTvo/VZ//7c8PT3eqrnTRvcF7JknkSsCsulPqSzuPnFAW nRF744P3k0ut8uIXSxcclWb59MHrJt8LhYizRpc3+SZ8abSeEDftpc/Dqo6LixMYDq31F8lU YinOSDTUYi4qTgQAuVEs3twCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsVy+t9jAd3uuoQgg6lLdSzmnG9hsbi88BKr xbEFYhYvr09ldWDx2LLyJpNH3+X/LB59W1YxenzeJBfAEtXAaJORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtFJJoSwxpxQoFJBYXKykb4dpQmiIm64F TGOErm9IEFyPkQEaSFjHmNFwbA17QR9bxbHFexkbGNtZuxg5OSQETCQ2/1rJBmGLSVy4tx7M FhJYxCjR0pENYf9ilGjcXA1iswmoSXz5cpi9i5GDQ0RAV2L+dROQMLNAksSbvw9YIMptJe7f ussMYnMK2Em0PzsJtkpYwFPizoJl7CA2i4CqxMIP3UwgNi9Q/dPPH9ggbEGJH5PvsUDM1JLY vK2JFcKWl9i85i0zyFoJAXWJR391QcIiAkYSMxfvZIMoEZHY9+Id4wRGoVlIJs1CMmkWkkmz kLQsYGRZxSiaWpBcUJyUnmuoV5yYW1yal66XnJ+7iREc7c+kdjCubLA4xCjAwajEw3vgW3yQ EGtiWXFl7iFGCQ5mJRHeVuGEICHelMTKqtSi/Pii0pzU4kOMyUCPTmSWEk3OByaivJJ4Q2MT MyNLIzMLIxNzc9KElcR5D7RaBwoJpCeWpGanphakFsFsYeLglGpg9LD8vj02lDF0Bsef/7Mv /r0rJiXCf+PSWWlOhtRb15n38+9JUV4kbMnxrI535ZP/Z3auv3+4/tDc9ZcuSITlzzglnuc1 kVH/aMDBj08SpmXdtYrX3nrv7Wwn/fhJdmlxf1izI/Ttli1Z5Bi/qGxJ2IxHXMfb5FhFP4lv TrlZOynagyOgTX5JhBJLcUaioRZzUXEiAJ1vWsY6AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Don Fry --- drivers/net/ethernet/amd/pcnet32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index bd4e640..38492e0 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -2818,7 +2818,6 @@ static void pcnet32_remove_one(struct pci_dev *pdev) lp->init_block, lp->init_dma_addr); free_netdev(dev); pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); } }