From patchwork Mon Oct 21 02:13:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 285079 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 350712C0087 for ; Mon, 21 Oct 2013 13:14:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370Ab3JUCOI (ORCPT ); Sun, 20 Oct 2013 22:14:08 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:19925 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101Ab3JUCOG (ORCPT ); Sun, 20 Oct 2013 22:14:06 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUZ00EFQY78E9G0@mailout4.samsung.com> for netdev@vger.kernel.org; Mon, 21 Oct 2013 11:13:58 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 9D.D0.07052.6ED84625; Mon, 21 Oct 2013 11:13:58 +0900 (KST) X-AuditID: cbfee691-b7f866d000001b8c-61-52648de656c2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 09.C8.08134.6ED84625; Mon, 21 Oct 2013 11:13:58 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUZ00L00Y7AH030@mmp2.samsung.com>; Mon, 21 Oct 2013 11:13:58 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, 'Jingoo Han' , 'Mirko Lindner' , 'Stephen Hemminger' References: <003801cece02$6abb0160$40310420$%han@samsung.com> In-reply-to: <003801cece02$6abb0160$40310420$%han@samsung.com> Subject: [PATCH 09/15] net: skge: remove unnecessary pci_set_drvdata() Date: Mon, 21 Oct 2013 11:13:58 +0900 Message-id: <004101cece03$337a9b60$9a6fd220$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7OAmqj3HcXTg4NSDu6YiXOSLcG+QAALrHA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t8zA91nvSlBBn8nqlvMOd/CYnF54SVW i7fHzjJZHFsgZrH4jpwDq8eWlTeZPCYvvMjs0XNyHpNH35ZVjB6fN8kFsEZx2aSk5mSWpRbp 2yVwZcx/o1fwi61iweRm1gbGJ6xdjJwcEgImEvu/fIOyxSQu3FvP1sXIxSEksIxR4uDp73BF V/btZYZITGeUuDVtP1TVL0aJ16uvgFWxCahJfPlymL2LkYNDREBXYv51E5AaZoE5jBI9T3eA 1QgJ2EocvPcfrIZTwE5i7qsMkLCwgJvE2T+HWEBsFgFViQsrF4CV8wKVt+1fyA5hC0r8mHwP rIZZQEti/c7jTBC2vMTmNW+ZQUZKCKhLPPqrCxIWETCS2DfvMVSJiMS+F+8YQc6RELjGLtEy cwYTxC4BiW+TQfaC9MpKbDrADPGvpMTBFTdYJjBKzEKyeRaSzbOQbJ6FZMUCRpZVjKKpBckF xUnpRaZ6xYm5xaV56XrJ+bmbGCExOnEH4/0D1ocYk4HWT2SWEk3OB8Z4Xkm8obGZkYWpiamx kbmlGWnCSuK86Y+SgoQE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwingpi+k3BdQqr+LnYCi2 u/LyNfOtw+uO2v1Rf3LtiPhVWePFMz5fqs2XTlhreDUlNCXjpdTrGz5b/gbZXfKQPdj3eK6n 8JTp11/5zQngCJVSKl6w0uzC+htp6eH2JUu+Xdj7s2NCTEXX4yfm/mvFZhYKbNRk0ZpyLeDp t3WKTp+25gbUiN8rV2Ipzkg01GIuKk4EAEB0m5HnAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIKsWRmVeSWpSXmKPExsVy+t9jQd1nvSlBBj2flC3mnG9hsbi88BKr xdtjZ5ksji0Qs1h8R86B1WPLyptMHpMXXmT26Dk5j8mjb8sqRo/Pm+QCWKMaGG0yUhNTUosU UvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgHYrKZQl5pQChQISi4uV 9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwnrGDPmv9Er+MVWsWByM2sD4xPWLkZODgkBE4kr+/Yy Q9hiEhfurWfrYuTiEBKYzihxa9p+KOcXo8Tr1VfAOtgE1CS+fDnM3sXIwSEioCsx/7oJSA2z wBxGiZ6nO8BqhARsJQ7e+w9WwylgJzH3VQZIWFjATeLsn0MsIDaLgKrEhZULwMp5gcrb9i9k h7AFJX5MvgdWwyygJbF+53EmCFteYvOat8wgIyUE1CUe/dUFCYsIGEnsm/cYqkREYt+Ld4wT GIVmIZk0C8mkWUgmzULSsoCRZRWjaGpBckFxUnqukV5xYm5xaV66XnJ+7iZGcAJ4Jr2DcVWD xSFGAQ5GJR7eAJeUICHWxLLiytxDjBIczEoivKkeQCHelMTKqtSi/Pii0pzU4kOMyUCPTmSW Ek3OByanvJJ4Q2MTMyNLIzMLIxNzc9KElcR5D7ZaBwoJpCeWpGanphakFsFsYeLglGpgXCFg yqZQ82xOtt4snlWnl6uEeX5mCE/pKZG5oad+6B9bpaWC3yTzqQsWf3xntll7gr/cSp7dtT0L w0MrjAOzZWp1u/2+3pFpdd+b8utPRlmSgrSR5TenI+53jsaqe4Y26h5ml/eOmXpF+MCfffLN Zj9iv9cu8lERPqgcp7830/O7+2yLqaJKLMUZiYZazEXFiQB5Kjh4RAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/marvell/skge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index ecc7f7b..5978461 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -4046,7 +4046,6 @@ err_out_free_regions: pci_release_regions(pdev); err_out_disable_pdev: pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); err_out: return err; } @@ -4090,7 +4089,6 @@ static void skge_remove(struct pci_dev *pdev) iounmap(hw->regs); kfree(hw); - pci_set_drvdata(pdev, NULL); } #ifdef CONFIG_PM_SLEEP