From patchwork Tue Oct 22 04:18:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 285355 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 626582C0092 for ; Tue, 22 Oct 2013 15:19:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628Ab3JVETI (ORCPT ); Tue, 22 Oct 2013 00:19:08 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:27524 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313Ab3JVETH (ORCPT ); Tue, 22 Oct 2013 00:19:07 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MV100BCKYNTHDL0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 22 Oct 2013 13:19:05 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 30.2F.06969.1BCF5625; Tue, 22 Oct 2013 13:18:57 +0900 (KST) X-AuditID: cbfee68f-b7f836d000001b39-d8-5265fcb18db5 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 52.AE.08134.1BCF5625; Tue, 22 Oct 2013 13:18:57 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MV100LF3YNLGYX0@mmp2.samsung.com>; Tue, 22 Oct 2013 13:18:57 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, 'Jingoo Han' , 'Francois Romieu' References: <000601cecedd$1981e300$4c85a900$%han@samsung.com> In-reply-to: <000601cecedd$1981e300$4c85a900$%han@samsung.com> Subject: [PATCH 10/15] net: sis190: remove unnecessary pci_set_drvdata() Date: Tue, 22 Oct 2013 13:18:57 +0900 Message-id: <001001cecedd$d3bd83f0$7b388bd0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7O3RlDcIH5J/QRSXSftoTU/CI5swAAKg4A Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t8zfd2Nf1KDDK4uMbCYc76FxeLywkus FscWiFn8avrM7MDisWXlTSaPr7P+MHv0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxtynlxkL Wtkqzl1tZG5g7GLtYuTkkBAwkVj4/gqULSZx4d56ti5GLg4hgWWMEn83LYArenT+PTOILSQw nVHi2m4TiKJfjBLXJ/0GK2ITUJP48uUwexcjB4eIgK7E/OsmIGFmgSyJua3bmSB6bSU2Xf8M ZnMK2El8f7qDDaRcWMBD4tt3F5Awi4CqxIvVk1hBwrxA5acnBYKEeQUEJX5MvscCMVFLYv3O 40wQtrzE5jVvmUHKJQTUJR791YXYbyTx+zEHRIWIxL4X7xgh/jjFLjH9AB/EIgGJb5MPsUB0 ykpsOsAMUSIpcXDFDZYJjBKzkOydhWTvLCR7ZyHZsICRZRWjaGpBckFxUnqRsV5xYm5xaV66 XnJ+7iZGSCT272C8e8D6EGMy0PqJzFKiyfnASM4riTc0NjOyMDUxNTYytzQjTVhJnPf+w6Qg IYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYyuT8K6jnb6pxQFH+rsldV4WFey7ETkcrt5t/Nn 31zwq2LJAZd9nNuWngtrDK88a60m1JnTdq8o4dYy7jfiWZul7yyZMvNhy/ElIarRqw7FXJm8 3yjz1vvq3R+PT8zw3Tj5W/rZtYd5L1ZWTjC3ZrnKevpp57znbz0LrokG1u9eLHk7wvl3wJql SizFGYmGWsxFxYkAE6pFItoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsVy+t9jQd2Nf1KDDD7t0LGYc76FxeLywkus FscWiFn8avrM7MDisWXlTSaPr7P+MHv0bVnF6PF5k1wAS1QDo01GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGEdY8bcp5cZC1rZKs5dbWRuYOxi7WLk5JAQMJF4dP49M4QtJnHh3no2 EFtIYDqjxLXdJl2MXED2L0aJ65N+gzWwCahJfPlymL2LkYNDREBXYv51E5Aws0CWxNzW7UwQ vbYSm65/BrM5Bewkvj/dwQZSLizgIfHtuwtImEVAVeLF6kmsIGFeoPLTkwJBwrwCghI/Jt9j gZioJbF+53EmCFteYvOat8wg5RIC6hKP/upC7DeS+P2YA6JCRGLfi3eMExiFZiEZNAvJoFlI Bs1C0rKAkWUVo2hqQXJBcVJ6rpFecWJucWleul5yfu4mRnCkP5PewbiqweIQowAHoxIPb4ZV apAQa2JZcWXuIUYJDmYlEd69R4BCvCmJlVWpRfnxRaU5qcWHGJOB3pzILCWanA9MQnkl8YbG JmZGlkZmFkYm5uakCSuJ8x5stQ4UEkhPLEnNTk0tSC2C2cLEwSnVwKhsXD51/v/Z+SWcW8NP PXkz6+OpjYI3LeX1aqY+U/5jXJygr5q8W81z34G5y/J1jm5yvHZIzTB9977ZXwWf1CfeV5/6 c978E9vnXitonKWTVVMdcTC6umC1nVX054zAntX185hOi1qmXFYWj9jSF/Dmqv/ctIxHVSz2 x66tVd4tvkmu8sQbhd1KLMUZiYZazEXFiQAOQU6VOAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/sis/sis190.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c index ee18e6f..acbbe48 100644 --- a/drivers/net/ethernet/sis/sis190.c +++ b/drivers/net/ethernet/sis/sis190.c @@ -1921,7 +1921,6 @@ static void sis190_remove_one(struct pci_dev *pdev) cancel_work_sync(&tp->phy_task); unregister_netdev(dev); sis190_release_board(pdev); - pci_set_drvdata(pdev, NULL); } static struct pci_driver sis190_pci_driver = {