From patchwork Mon Nov 25 01:56:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 293794 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5655B2C00A7 for ; Mon, 25 Nov 2013 12:56:41 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109Ab3KYB4i (ORCPT ); Sun, 24 Nov 2013 20:56:38 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:11184 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433Ab3KYB4g (ORCPT ); Sun, 24 Nov 2013 20:56:36 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWS003N5QQB15B0@mailout1.samsung.com> for netdev@vger.kernel.org; Mon, 25 Nov 2013 10:56:35 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id CB.ED.18301.35EA2925; Mon, 25 Nov 2013 10:56:35 +0900 (KST) X-AuditID: cbfee68e-b7f7e6d00000477d-b9-5292ae535e18 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9E.5A.02580.35EA2925; Mon, 25 Nov 2013 10:56:35 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MWS002O2QQB3K70@mmp2.samsung.com>; Mon, 25 Nov 2013 10:56:35 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, 'Jingoo Han' , 'Francois Romieu' Subject: [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Date: Mon, 25 Nov 2013 10:56:35 +0900 Message-id: <000b01cee981$9254d850$b6fe88f0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7pgZIvp/JST/04TBSwBRBWyr7A7Q== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t8zY93gdZOCDI4/NrSYc76FxeLywkus FscWiFn8avrM7MDisWXlTSaPr7P+MHv0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxoc5ZxgL XrNWvDu7l62B8T5LFyMnh4SAicSm1cuhbDGJC/fWs3UxcnEICSxjlFjysokVpujHxsMsEInp jBLvnr1lhHB+MUrcffMCrIpNQE3iy5fD7F2MHBwiAroS86+bgISZBbIk5rZuZwKxhQVcJdbd 3sEGYrMIqEqs27QBbDOvgK3E6uY97BC2oMSPyfdYIHq1JNbvPM4EYctLbF7zlhlkvISAusSj v7ogYREBPYkpt46yQ5SISOx78Q7sNAmBbewSlw7B7BKQ+Db5EAtEr6zEpgPMEH9JShxccYNl AqPYLCSbZyHZPAvJ5llIVixgZFnFKJpakFxQnJReZKRXnJhbXJqXrpecn7uJERJjfTsYbx6w PsSYDLR+IrOUaHI+MEbzSuINjc2MLExNTI2NzC3NSBNWEudd9DApSEggPbEkNTs1tSC1KL6o NCe1+BAjEwenVAMjj0k+/9YPG6f7L7qi+O9RhbeLetWvhqP57x7LT9Lvi+sUmXupQPpVEM8X 1VauSwXfjrPY6rbn2VW2sflN4dNmmf7r3M09PLNm5CicnLp3Tv5lowvtFZ4xe35nnqkynjNH ae6JRKWH/O4ZkicZd/5dc8lWv6ly59kyhrvn1QOt+2Pabv5cP9NbiaU4I9FQi7moOBEA7C80 98cCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jQd3gdZOCDJZu0bOYc76FxeLywkus FscWiFn8avrM7MDisWXlTSaPr7P+MHv0bVnF6PF5k1wAS1QDo01GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGEdY8aHOWcYC16zVrw7u5etgfE+SxcjJ4eEgInEj42HoWwxiQv31rN1 MXJxCAlMZ5R49+wtI4Tzi1Hi7psXrCBVbAJqEl++HGbvYuTgEBHQlZh/3QQkzCyQJTG3dTsT iC0s4Cqx7vYONhCbRUBVYt2mDWALeAVsJVY372GHsAUlfky+xwLRqyWxfudxJghbXmLzmrfM IOMlBNQlHv3VBQmLCOhJTLl1lB2iRERi34t3jBMYBWYhmTQLyaRZSCbNQtKygJFlFaNoakFy QXFSeq6hXnFibnFpXrpecn7uJkZwBD+T2sG4ssHiEKMAB6MSD69F5aQgIdbEsuLK3EOMEhzM SiK8e+qAQrwpiZVVqUX58UWlOanFhxiTgR6dyCwlmpwPTC55JfGGxiZmRpZGZhZGJubmpAkr ifMeaLUOFBJITyxJzU5NLUgtgtnCxMEp1cDoFPA5dXPmtSXS3Jt97U1m/UiM2GQau/KJkNF0 07n9wcyvl866Mr8wqFA1sZ+54bicQZ6r6Y5dSdKfVO/+Lvwh49b25sO1Q2eWuNXOXvXk45yE UJmll/Yx7L3zaE6o7NZATaOsKfxpMyurbi+/onAlPU7mRXPDP7OVW7mPd3CLH+j8zpP8Oeyi EktxRqKhFnNRcSIAmUCCQyQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/wan/dscc4.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c index 851dc7b..288610d 100644 --- a/drivers/net/wan/dscc4.c +++ b/drivers/net/wan/dscc4.c @@ -699,8 +699,6 @@ static void dscc4_free1(struct pci_dev *pdev) for (i = 0; i < dev_per_card; i++) unregister_hdlc_device(dscc4_to_dev(root + i)); - pci_set_drvdata(pdev, NULL); - for (i = 0; i < dev_per_card; i++) free_netdev(root[i].dev); kfree(root);