From patchwork Tue Oct 22 04:16:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 285350 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AF8BE2C012D for ; Tue, 22 Oct 2013 15:16:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409Ab3JVEQj (ORCPT ); Tue, 22 Oct 2013 00:16:39 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:53619 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874Ab3JVEQi (ORCPT ); Tue, 22 Oct 2013 00:16:38 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MV100A6RYIGQV70@mailout1.samsung.com> for netdev@vger.kernel.org; Tue, 22 Oct 2013 13:16:37 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id FE.34.07242.52CF5625; Tue, 22 Oct 2013 13:16:37 +0900 (KST) X-AuditID: cbfee690-b7f3d6d000001c4a-61-5265fc251af7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id C9.2E.08134.52CF5625; Tue, 22 Oct 2013 13:16:37 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MV100LQDYJPGYW0@mmp2.samsung.com>; Tue, 22 Oct 2013 13:16:37 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, 'Jingoo Han' , 'Jitendra Kalsaria' , 'Ron Mercer' References: <000601cecedd$1981e300$4c85a900$%han@samsung.com> In-reply-to: <000601cecedd$1981e300$4c85a900$%han@samsung.com> Subject: [PATCH 05/15] net: qla3xxx: remove unnecessary pci_set_drvdata() Date: Tue, 22 Oct 2013 13:16:37 +0900 Message-id: <000b01cecedd$8052b000$80f81000$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7O3RlDcIH5J/QRSXSftoTU/CI5swAAFa6A Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t8zY13VP6lBBvMXmFjMOd/CYnF54SVW iwlHfjNaHFsgZvHs0xkmB1aPLStvMnms+3KC3aNvyypGj8+b5AJYorhsUlJzMstSi/TtErgy Nn4/yFawiL1i6oJW5gbGHrYuRk4OCQETiZZdM5kgbDGJC/fWA8W5OIQEljFKvP51ihmmaEXP AyaIxHRGid2dzawQzi9GiS9NJ8BGsQmoSXz5cpi9i5GDQ0RAV2L+dROQMLPAHEaJM2e0QWwh AVuJTdc/g23jFLCT+P50B1irsICnxNUVT1lAWlkEVCXuTJMECfMClZ87cI0VwhaU+DH5HgvE SC2J9TuPM0HY8hKb17xlBmmVEFCXePRXFyQsImAk8XFDLxtEiYjEvhfvGEEulhC4xC5xoPsy 2EwWAQGJb5MPsUD0ykpsOgD1rqTEwRU3WCYwSsxCsnkWks2zkGyehWTFAkaWVYyiqQXJBcVJ 6UUmesWJucWleel6yfm5mxghsTlhB+O9A9aHGJOB1k9klhJNzgfGdl5JvKGxmZGFqYmpsZG5 pRlpwkrivGqPkoKEBNITS1KzU1MLUovii0pzUosPMTJxcEo1MDLfLD9+Ptfe4v3JYFZetv07 j2npP56dGHS04FvtjN3x3reYDdb3LhFcudRfjGlO9Js/cktNb8o8yagKfZ2Z3uFbtlVj4q+s 3ZLz2ycoZ3erPe+dktzzptW/2oa15f/qjHsrbu2X3/WAUcj02oZX0xTv3b4fWx6zr3JBsqC9 1BFDv5zY0uzzZkosxRmJhlrMRcWJAKCAKbrjAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsVy+t9jQV3VP6lBBpcPGFjMOd/CYnF54SVW iwlHfjNaHFsgZvHs0xkmB1aPLStvMnms+3KC3aNvyypGj8+b5AJYohoYbTJSE1NSixRS85Lz UzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOA9ioplCXmlAKFAhKLi5X07TBN CA1x07WAaYzQ9Q0JgusxMkADCesYMzZ+P8hWsIi9YuqCVuYGxh62LkZODgkBE4kVPQ+YIGwx iQv31gPFuTiEBKYzSuzubGaFcH4xSnxpOgHWwSagJvHly2H2LkYODhEBXYn5101AwswCcxgl zpzRBrGFBGwlNl3/DDaUU8BO4vvTHWCtwgKeEldXPGUBaWURUJW4M00SJMwLVH7uwDVWCFtQ 4sfkeywQI7Uk1u88zgRhy0tsXvOWGaRVQkBd4tFfXZCwiICRxMcNvWwQJSIS+168Y5zAKDQL yaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGCI/+Z9A7GVQ0WhxgF OBiVeHgzrFKDhFgTy4orcw8xSnAwK4nw7j0CFOJNSaysSi3Kjy8qzUktPsSYDPTnRGYp0eR8 YFLKK4k3NDYxM7I0MrMwMjE3J01YSZz3YKt1oJBAemJJanZqakFqEcwWJg5OqQZG15zJUmKV 7ns0I/zPy17afrTaXiau7tuuRrE/M7z/9si0nGJ89tq51sxH5iyrctoajk179NiMzr34yMB8 a+cjzYBndaqZAjJt/z8VuR1LdXXqmCG65EHB4ecyLOe9p3tp3Xtb/yDRe3bWmqAG2YI6Ttcz T5WquI46nI1XzYlKnau23cBPhUGJpTgj0VCLuag4EQCo0PZ/QAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/qlogic/qla3xxx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 91a8fcd..0758b94 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -3916,7 +3916,6 @@ err_out_free_regions: pci_release_regions(pdev); err_out_disable_pdev: pci_disable_device(pdev); - pci_set_drvdata(pdev, NULL); err_out: return err; } @@ -3939,7 +3938,6 @@ static void ql3xxx_remove(struct pci_dev *pdev) iounmap(qdev->mem_map_registers); pci_release_regions(pdev); - pci_set_drvdata(pdev, NULL); free_netdev(ndev); }