From patchwork Mon Nov 25 01:54:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 293792 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E11ED2C0084 for ; Mon, 25 Nov 2013 12:54:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962Ab3KYByd (ORCPT ); Sun, 24 Nov 2013 20:54:33 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:49028 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303Ab3KYByc (ORCPT ); Sun, 24 Nov 2013 20:54:32 -0500 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWS003OCQMVPOC0@mailout3.samsung.com> for netdev@vger.kernel.org; Mon, 25 Nov 2013 10:54:31 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id E5.5B.18459.7DDA2925; Mon, 25 Nov 2013 10:54:31 +0900 (KST) X-AuditID: cbfee68f-b7f336d00000481b-ec-5292add76914 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 55.8D.01270.7DDA2925; Mon, 25 Nov 2013 10:54:31 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MWS004VMQMVXG10@mmp2.samsung.com>; Mon, 25 Nov 2013 10:54:31 +0900 (KST) From: Jingoo Han To: 'David Miller' Cc: netdev@vger.kernel.org, 'Samuel Ortiz' , 'Jingoo Han' Subject: [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata() Date: Mon, 25 Nov 2013 10:54:31 +0900 Message-id: <000901cee981$483ca4f0$d8b5eed0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7pgURlaNno+0s9Q+OoFDafL/fK6w== Content-language: ko x-cr-hashedpuzzle: D0Do HEvh Kw8w L3T8 OijF OtWf UGfK UngU WU0i aEwT bSXl fguG g8GG ip6U kNsm pyCY; 4; ZABhAHYAZQBtAEAAZABhAHYAZQBtAGwAbwBmAHQALgBuAGUAdAA7AGoAZwAxAC4AaABhAG4AQABzAGEAbQBzAHUAbgBnAC4AYwBvAG0AOwBuAGUAdABkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcwBhAG0AdQBlAGwAQABzAG8AcgB0AGkAegAuAG8AcgBnAA==; Sosha1_v1; 7; {6CD22FB6-AFD4-4F95-820A-192B15C331D7}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Mon, 25 Nov 2013 01:54:24 GMT; WwBQAEEAVABDAEgAIAAxAC8AMgBdACAAaQByAGQAYQA6ACAAdgBpAGEALQBpAHIAYwBjADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {6CD22FB6-AFD4-4F95-820A-192B15C331D7} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t8zY93raycFGTSvk7aYc76FxeLywkus FscWiFm83beN2YHFY8vKm0wefVtWMXpMeZ3i8XmTXABLFJdNSmpOZllqkb5dAlfGwdtfmQu+ sVfMnXKRsYHxFFsXIyeHhICJRPfWJkYIW0ziwr31YHEhgWWMEk0fomFqHm5+z9TFyAUUn84o cXP6HnYI5xejxJb2I2AdbAJqEl++HGYHsUUENCRO/m1kArGZBVIk3p5rB7I5OIQFPCWajjuC hFkEVCWu3pzNAhLmFbCVaPypChLmFRCU+DH5HgtEp5bE+p3HoabIS2xe85YZpFxCQF3i0V9d iEV6EjO3XoUqF5HY9+IdI8hlEgI/WCRWnp7ABHG/qcTTezPYIBKn2CX2nF7BBHGDgMS3yYdY IIbKSmw6wAxRLylxcMUNlgmMErOQnDQLyUmzkJw0C8nuBYwsqxhFUwuSC4qT0ouM9YoTc4tL 89L1kvNzNzFC4rF/B+PdA9aHGJOB1k9klhJNzgfGc15JvKGxmZGFqYmpsZG5pRlpwkrivPcf JgUJCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYKzWZ7Q2OvX1//3Co7O2Fm6w7501cSfnI969 4lcFJv/bOSe86xlzTbL51Tsz5umyH7oknrqWT+aamendrJpbnz7vyZK49y3i4FS5E2/OH73H uLePZ/vDFUcZU+S77SbuYefbcMOm+8GC0/9mPK06POfttrPqRhYnglpfPd01V3XR3I25QY07 zkpJKbEUZyQaajEXFScCAEcyiPDdAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t9jQd3raycFGVx4K24x53wLi8XlhZdY LY4tELN4u28bswOLx5aVN5k8+rasYvSY8jrF4/MmuQCWqAZGm4zUxJTUIoXUvOT8lMy8dFsl 7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygjUoKZYk5pUChgMTiYiV9O0wTQkPcdC1g GiN0fUOC4HqMDNBAwjrGjIO3vzIXfGOvmDvlImMD4ym2LkZODgkBE4mHm98zQdhiEhfurQeK c3EICUxnlLg5fQ87hPOLUWJL+xGwDjYBNYkvXw6zg9giAhoSJ/82gnUzC6RIvD3XDmRzcAgL eEo0HXcECbMIqEpcvTmbBSTMK2Ar0fhTFSTMKyAo8WPyPRaITi2J9TuPQ02Rl9i85i0zSLmE gLrEo7+6EIv0JGZuvQpVLiKx78U7RpDLJAR+sEisPD0B6n5Tiaf3ZrBNYBSahWTFLCQrZiFZ MQvJrAWMLKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxguP9mfQOxlUNFocYBTgYlXh4J1ZP ChJiTSwrrsw9xCjBwawkwrunDijEm5JYWZValB9fVJqTWnyIMRkYABOZpUST84GpKK8k3tDY xMzI0sjMwsjE3Jw0YSVx3oOt1oFCAumJJanZqakFqUUwW5g4OKUaGBNvXr83OW7L4W3zjrwU y7senq/5fsu/Bj2dmwcr/kw6vnipSNSGz9sUDT75XZS2Ns9aMe9dH9N0j8VbhTIq3h7ckC02 cY3rVka/xtYrh2vk2XYF7lgtudxFsHujoLMGn5jgOwvHOTHCDtffN3LPudcoOkF3gt3WTU/f aV9c1rzP2nKGe8W1+b5KLMUZiYZazEXFiQCGfGBGOwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/irda/via-ircc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c index 9abaec2..b0e8207 100644 --- a/drivers/net/irda/via-ircc.c +++ b/drivers/net/irda/via-ircc.c @@ -408,7 +408,6 @@ static int via_ircc_open(struct pci_dev *pdev, chipio_t *info, unsigned int id) err_out2: release_region(self->io.fir_base, self->io.fir_ext); err_out1: - pci_set_drvdata(pdev, NULL); free_netdev(dev); return err; } @@ -442,7 +441,6 @@ static void via_remove_one(struct pci_dev *pdev) if (self->rx_buff.head) dma_free_coherent(&pdev->dev, self->rx_buff.truesize, self->rx_buff.head, self->rx_buff_dma); - pci_set_drvdata(pdev, NULL); free_netdev(self->netdev);