From patchwork Tue May 28 05:07:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 246698 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 528532C02CE for ; Tue, 28 May 2013 15:07:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384Ab3E1FHQ (ORCPT ); Tue, 28 May 2013 01:07:16 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49935 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124Ab3E1FHO (ORCPT ); Tue, 28 May 2013 01:07:14 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MNH00HA4SVP3DO0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 28 May 2013 14:07:13 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 76.EF.11618.08B34A15; Tue, 28 May 2013 14:07:12 +0900 (KST) X-AuditID: cbfee691-b7fef6d000002d62-87-51a43b80b1a1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9F.98.21068.08B34A15; Tue, 28 May 2013 14:07:12 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MNH00M3KSW0L5A0@mmp2.samsung.com>; Tue, 28 May 2013 14:07:12 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , "'John W. Linville'" , 'Jiri Slaby' , 'Nick Kossifidis' , "'Luis R. Rodriguez'" , 'Jouni Malinen' , 'Vasanthakumar Thiagarajan' , 'Senthil Balasubramanian' Subject: [PATCH V2 3/4] net: wireless: remove unnecessary platform_set_drvdata() Date: Tue, 28 May 2013 14:07:11 +0900 Message-id: <000301ce5b61$368e3dd0$a3aab970$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5bYM0czfVANlBzSe+cC3RndvdICA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsVy+t8zA90G6yWBBnf/G1nMOd/CYnF54SVW i3cnjrJa/F9kaLG1R8Ki4cgLdovVF3ayWhxbIGax9+seJotVc78wOXB5bFl5k8lj56y77B6H Phxh9ejbsorR48r31YwenzfJBbBFcdmkpOZklqUW6dslcGVcnHKeueAqb8Xp53+YGxh3cXcx cnJICJhIHO68wAxhi0lcuLeerYuRi0NIYBmjxMdr+9hhiqZ9+sYEkZjOKNF+ZAMrhPOLUWLu i59MIFVsAmoSX74cBurg4BAR0JWYf90EpIZZoJ9ZYtW+VawgNcICARIL/yxiAbFZBFQljr1Y yQZSzytgKfFzgzxImFdAUOLH5HtgJcwCWhLrdx5ngrDlJTaveQt1qYLEjrOvGUFsEQE9iQm7 tkLVi0jse/GOEWSvhMBXdondZz9D7RKQ+Db5EAvILgkBWYlNB6DmSEocXHGDZQKj2Cwkq2ch WT0LyepZSFYsYGRZxSiaWpBcUJyUXmSqV5yYW1yal66XnJ+7iRESsRN3MN4/YH2IMRlo/URm KdHkfGDE55XEGxqbGVmYmpgaG5lbmpEmrCTOq95iHSgkkJ5YkpqdmlqQWhRfVJqTWnyIkYmD U6qB0d56U8LsL2Z3zW5u3MqWz6p55dYk+yOGe2as6itfdaFBy7fkU67o58NaAtaXm91Smj/n evBqX7szi2Xak9ndr7bUh7xT+68SdePTrsdamg9vcXSoy93XbZiet2uuf7RhPtPnirVTZ17s erH9ndzhu0ah2js/F83+0b0idiZP4gr5QlGF7pczXiuxFGckGmoxFxUnAgA7+5657gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRmVeSWpSXmKPExsVy+t9jQd0G6yWBBveW6FnMOd/CYnF54SVW i3cnjrJa/F9kaLG1R8Ki4cgLdovVF3ayWhxbIGax9+seJotVc78wOXB5bFl5k8lj56y77B6H Phxh9ejbsorR48r31YwenzfJBbBFNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpa mCsp5CXmptoqufgE6Lpl5gAdpqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0k rGPMuDjlPHPBVd6K08//MDcw7uLuYuTkkBAwkZj26RsThC0mceHeerYuRi4OIYHpjBLtRzaw Qji/GCXmvvgJVsUmoCbx5cth9i5GDg4RAV2J+ddNQGqYBfqZJVbtW8UKUiMsECCx8M8iFhCb RUBV4tiLlWwg9bwClhI/N8iDhHkFBCV+TL4HVsIsoCWxfudxJghbXmLzmrfMEAcpSOw4+5oR xBYR0JOYsGsrVL2IxL4X7xgnMArMQjJqFpJRs5CMmoWkZQEjyypG0dSC5ILipPRcI73ixNzi 0rx0veT83E2M4HTwTHoH46oGi0OMAhyMSjy8E7IXBwqxJpYVV+YeYpTgYFYS4d2+AijEm5JY WZValB9fVJqTWnyIMRno0YnMUqLJ+cBUlVcSb2hsYmZkaWRmYWRibk6asJI478FW60AhgfTE ktTs1NSC1CKYLUwcnFINjFLsBWm3jNg5wzj3Nfzk1Pf7ziSTv1x+Q3PWhStNVQmfkkPEP+UY 2mr5Xje4/2/Ktqjdc06LFvi2Hy7UnjWF5/jMfen3Jlm+XLnw0dRdN7innnyXv0xb2OnNZ/c1 S8Vfi5fqvGT/b9ue5TrD7+mfJ5oPJrRP4tqSdtEz0F6c9fbTebEHA6Y0WymxFGckGmoxFxUn AgD+LygdSwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/wireless/ath/ath5k/ahb.c | 2 -- drivers/net/wireless/ath/ath9k/ahb.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c index 8e8bcc7a..e9bc9e6 100644 --- a/drivers/net/wireless/ath/ath5k/ahb.c +++ b/drivers/net/wireless/ath/ath5k/ahb.c @@ -185,7 +185,6 @@ static int ath_ahb_probe(struct platform_device *pdev) err_free_hw: ieee80211_free_hw(hw); - platform_set_drvdata(pdev, NULL); err_iounmap: iounmap(mem); err_out: @@ -221,7 +220,6 @@ static int ath_ahb_remove(struct platform_device *pdev) ath5k_deinit_ah(ah); iounmap(ah->iobase); - platform_set_drvdata(pdev, NULL); ieee80211_free_hw(hw); return 0; diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c index d1ff3c2..072e4b5 100644 --- a/drivers/net/wireless/ath/ath9k/ahb.c +++ b/drivers/net/wireless/ath/ath9k/ahb.c @@ -150,7 +150,6 @@ static int ath_ahb_probe(struct platform_device *pdev) free_irq(irq, sc); err_free_hw: ieee80211_free_hw(hw); - platform_set_drvdata(pdev, NULL); return ret; } @@ -164,7 +163,6 @@ static int ath_ahb_remove(struct platform_device *pdev) ath9k_deinit_device(sc); free_irq(sc->irq, sc); ieee80211_free_hw(sc->hw); - platform_set_drvdata(pdev, NULL); } return 0;