diff mbox

[1/1] net: replace if()/BUG with BUG_ON()

Message ID "000201d0a728$e1928230$a4b78690$@s"@samsung.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Maninder Singh June 15, 2015, 5:05 a.m. UTC 
Use BUG_ON(condition) instead of if(condition)/BUG()

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 net/packet/af_packet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

 			GET_PBDQC_FROM_RB(&po->rx_ring);

Comments

David Miller June 16, 2015, 12:12 a.m. UTC | #1 
From: Maninder Singh <maninder1.s@samsung.com>
Date: Mon, 15 Jun 2015 10:35:05 +0530

> Use BUG_ON(condition) instead of if(condition)/BUG()
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>

Your email client corrupted this patch, making it unusable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b5989c6..c91d405 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -547,8 +547,7 @@  static void prb_setup_retire_blk_timer(struct
packet_sock *po, int tx_ring)
 {
 	struct tpacket_kbdq_core *pkc;
 
-	if (tx_ring)
-		BUG();
+	BUG_ON(tx_ring);
 
 	pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :