| Message ID | eda2de73-edf2-8b92-edb9-099ebda09ebc@solarflare.com |
|---|---|
| Headers | show |
| Series | sfc: further EF100 encap TSO features | expand |
On Thu, Nov 12, 2020 at 03:18:01PM +0000, Edward Cree wrote: > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros to 19 fields > sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100 > sfc: support GRE TSO on EF100 Acked-by: Martin Habets <mhabets@solarflare.com>
On Thu, Nov 12, 2020 at 7:19 AM Edward Cree <ecree@solarflare.com> wrote: > > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros to 19 fields > sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100 > sfc: support GRE TSO on EF100 > > drivers/net/ethernet/sfc/bitfield.h | 26 +++++++++++++++++++++----- > drivers/net/ethernet/sfc/ef100_nic.c | 8 ++++++-- > drivers/net/ethernet/sfc/ef100_tx.c | 12 ++++++++++-- > 3 files changed, 37 insertions(+), 9 deletions(-) > The code itself is mostly solid. The only issue I see is a question I have about if we really need to be defining so many of the "EFX_POPULATE_..." macros in patch 1 as it seems a bit gratuitous and could likely be replaced by just adding multiple dummy fields to a single macro instead of defining multiple macros to get to the end goal. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 15:18:01 +0000 you wrote: > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros to 19 fields > sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100 > sfc: support GRE TSO on EF100 > > [...] Here is the summary with links: - [net-next,1/3] sfc: extend bitfield macros to 19 fields https://git.kernel.org/netdev/net-next/c/dc8d2512e697 - [net-next,2/3] sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100 https://git.kernel.org/netdev/net-next/c/42bfd69a9fdd - [net-next,3/3] sfc: support GRE TSO on EF100 https://git.kernel.org/netdev/net-next/c/c5122cf58412 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html