mbox series

[net-next,0/2] lib: string: add strreplace_nonalnum

Message ID d92b7418-09bb-15bc-85f8-508f992ed2c6@gmail.com
Headers show
Series lib: string: add strreplace_nonalnum | expand

Message

Heiner Kallweit March 3, 2019, 5:19 p.m. UTC
Add a new function strreplace_nonalnum that replaces all
non-alphanumeric characters. Such functionality is needed e.g. when a
string is supposed to be used in a file name. If '\0' is given as new
character then non-alphanumeric characters are cut. 

There doesn't seem to be a maintainer or mailing list for lib/string.c
Therefore I hope it's ok to submit this through the netdev tree.

Heiner Kallweit (2):
  lib: string: add strreplace_nonalnum
  net: phy: aquantia: use new function strreplace_nonalnum

 drivers/net/phy/aquantia_hwmon.c | 10 +---------
 include/linux/string.h           |  1 +
 lib/string.c                     | 27 +++++++++++++++++++++++++++
 3 files changed, 29 insertions(+), 9 deletions(-)

Comments

Andrew Lunn March 3, 2019, 5:34 p.m. UTC | #1
On Sun, Mar 03, 2019 at 06:19:35PM +0100, Heiner Kallweit wrote:
> There doesn't seem to be a maintainer or mailing list for lib/string.c
> Therefore I hope it's ok to submit this through the netdev tree.

Hi Heiner

It is probably a good idea to Cc:

~/linux$ ./scripts/get_maintainer.pl -f lib/string.c
Alexander Shishkin <alexander.shishkin@linux.intel.com> (commit_signer:2/2=100%,authored:2/2=100%,added_lines:31/31=100%,removed_lines:30/30=100%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:2/2=100%)
Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer:1/2=50%)
linux-kernel@vger.kernel.org (open list)

And also Guenter Roeck who does most of the HWMON maintenance work.

    Andrew
Heiner Kallweit March 3, 2019, 5:39 p.m. UTC | #2
On 03.03.2019 18:34, Andrew Lunn wrote:
> On Sun, Mar 03, 2019 at 06:19:35PM +0100, Heiner Kallweit wrote:
>> There doesn't seem to be a maintainer or mailing list for lib/string.c
>> Therefore I hope it's ok to submit this through the netdev tree.
> 
> Hi Heiner
> 
> It is probably a good idea to Cc:
> 
> ~/linux$ ./scripts/get_maintainer.pl -f lib/string.c
> Alexander Shishkin <alexander.shishkin@linux.intel.com> (commit_signer:2/2=100%,authored:2/2=100%,added_lines:31/31=100%,removed_lines:30/30=100%)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:2/2=100%)
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> (commit_signer:1/2=50%)
> linux-kernel@vger.kernel.org (open list)
> 

Strange, when I use get_maintainer.pl with the patch I get the following only:

[root@hkvirt linux-next]# scripts/get_maintainer.pl 0001-lib-string-add-strreplace_nonalnum.patch
Stephen Rothwell <sfr@canb.auug.org.au> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:479/479=100%,added_lines:1055/1055=100%)
linux-kernel@vger.kernel.org (open list)

Therefore I sent it to the usual suspects only.

> And also Guenter Roeck who does most of the HWMON maintenance work.
> 
Right.

>     Andrew
> 
Heiner
Heiner Kallweit March 3, 2019, 6:36 p.m. UTC | #3
On 03.03.2019 18:19, Heiner Kallweit wrote:
> Add a new function strreplace_nonalnum that replaces all
> non-alphanumeric characters. Such functionality is needed e.g. when a
> string is supposed to be used in a file name. If '\0' is given as new
> character then non-alphanumeric characters are cut. 
> 
> There doesn't seem to be a maintainer or mailing list for lib/string.c
> Therefore I hope it's ok to submit this through the netdev tree.
> 
> Heiner Kallweit (2):
>   lib: string: add strreplace_nonalnum
>   net: phy: aquantia: use new function strreplace_nonalnum
> 
>  drivers/net/phy/aquantia_hwmon.c | 10 +---------
>  include/linux/string.h           |  1 +
>  lib/string.c                     | 27 +++++++++++++++++++++++++++
>  3 files changed, 29 insertions(+), 9 deletions(-)
> 
Greg still has some concerns, let's see what the outcome of this
discussion is.
https://lkml.org/lkml/2019/3/3/151
Heiner Kallweit March 4, 2019, 6:54 p.m. UTC | #4
On 03.03.2019 19:36, Heiner Kallweit wrote:
> On 03.03.2019 18:19, Heiner Kallweit wrote:
>> Add a new function strreplace_nonalnum that replaces all
>> non-alphanumeric characters. Such functionality is needed e.g. when a
>> string is supposed to be used in a file name. If '\0' is given as new
>> character then non-alphanumeric characters are cut. 
>>
>> There doesn't seem to be a maintainer or mailing list for lib/string.c
>> Therefore I hope it's ok to submit this through the netdev tree.
>>
>> Heiner Kallweit (2):
>>   lib: string: add strreplace_nonalnum
>>   net: phy: aquantia: use new function strreplace_nonalnum
>>
>>  drivers/net/phy/aquantia_hwmon.c | 10 +---------
>>  include/linux/string.h           |  1 +
>>  lib/string.c                     | 27 +++++++++++++++++++++++++++
>>  3 files changed, 29 insertions(+), 9 deletions(-)
>>
> Greg still has some concerns, let's see what the outcome of this
> discussion is.
> https://lkml.org/lkml/2019/3/3/151
> 
This series should be deferred to next merge window.

Heiner
David Miller March 4, 2019, 7:22 p.m. UTC | #5
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 4 Mar 2019 19:54:16 +0100

> On 03.03.2019 19:36, Heiner Kallweit wrote:
>> On 03.03.2019 18:19, Heiner Kallweit wrote:
>>> Add a new function strreplace_nonalnum that replaces all
>>> non-alphanumeric characters. Such functionality is needed e.g. when a
>>> string is supposed to be used in a file name. If '\0' is given as new
>>> character then non-alphanumeric characters are cut. 
>>>
>>> There doesn't seem to be a maintainer or mailing list for lib/string.c
>>> Therefore I hope it's ok to submit this through the netdev tree.
>>>
>>> Heiner Kallweit (2):
>>>   lib: string: add strreplace_nonalnum
>>>   net: phy: aquantia: use new function strreplace_nonalnum
>>>
>>>  drivers/net/phy/aquantia_hwmon.c | 10 +---------
>>>  include/linux/string.h           |  1 +
>>>  lib/string.c                     | 27 +++++++++++++++++++++++++++
>>>  3 files changed, 29 insertions(+), 9 deletions(-)
>>>
>> Greg still has some concerns, let's see what the outcome of this
>> discussion is.
>> https://lkml.org/lkml/2019/3/3/151
>> 
> This series should be deferred to next merge window.

Ok I'll revert, sorry I just saw this.
Heiner Kallweit March 4, 2019, 7:27 p.m. UTC | #6
On 04.03.2019 20:22, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Mon, 4 Mar 2019 19:54:16 +0100
> 
>> On 03.03.2019 19:36, Heiner Kallweit wrote:
>>> On 03.03.2019 18:19, Heiner Kallweit wrote:
>>>> Add a new function strreplace_nonalnum that replaces all
>>>> non-alphanumeric characters. Such functionality is needed e.g. when a
>>>> string is supposed to be used in a file name. If '\0' is given as new
>>>> character then non-alphanumeric characters are cut. 
>>>>
>>>> There doesn't seem to be a maintainer or mailing list for lib/string.c
>>>> Therefore I hope it's ok to submit this through the netdev tree.
>>>>
>>>> Heiner Kallweit (2):
>>>>   lib: string: add strreplace_nonalnum
>>>>   net: phy: aquantia: use new function strreplace_nonalnum
>>>>
>>>>  drivers/net/phy/aquantia_hwmon.c | 10 +---------
>>>>  include/linux/string.h           |  1 +
>>>>  lib/string.c                     | 27 +++++++++++++++++++++++++++
>>>>  3 files changed, 29 insertions(+), 9 deletions(-)
>>>>
>>> Greg still has some concerns, let's see what the outcome of this
>>> discussion is.
>>> https://lkml.org/lkml/2019/3/3/151
>>>
>> This series should be deferred to next merge window.
> 
> Ok I'll revert, sorry I just saw this.
> 
Thank you!