mbox series

[iproute2,v2,0/3] do not set IPv6-only options on IPv4 addresses

Message ID cover.1561457597.git.aclaudi@redhat.com
Headers show
Series do not set IPv6-only options on IPv4 addresses | expand

Message

Andrea Claudi June 25, 2019, 10:29 a.m. UTC 
'home', 'nodad' and 'mngtmpaddr' options are IPv6-only, but
it is possible to set them on IPv4 addresses, too. This should
not be possible.

Fix this adding a check on the protocol family before setting
the flags, and print warning messages on error to not break
existing scripted setups.

Andrea Claudi (3):
  ip address: do not set nodad option for IPv4 addresses
  ip address: do not set home option for IPv4 addresses
  ip address: do not set mngtmpaddr option for IPv4 addresses

 ip/ipaddress.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Comments

Stephen Hemminger June 28, 2019, 10:20 p.m. UTC | #1 
On Tue, 25 Jun 2019 12:29:54 +0200
Andrea Claudi <aclaudi@redhat.com> wrote:

> 'home', 'nodad' and 'mngtmpaddr' options are IPv6-only, but
> it is possible to set them on IPv4 addresses, too. This should
> not be possible.
> 
> Fix this adding a check on the protocol family before setting
> the flags, and print warning messages on error to not break
> existing scripted setups.
> 
> Andrea Claudi (3):
>   ip address: do not set nodad option for IPv4 addresses
>   ip address: do not set home option for IPv4 addresses
>   ip address: do not set mngtmpaddr option for IPv4 addresses
> 
>  ip/ipaddress.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 

Series applied. Thanks