mbox series

[net,0/3] a couple of fixes for chunks abandoned in prsctp

Message ID cover.1511615658.git.lucien.xin@gmail.com
Headers show
Series a couple of fixes for chunks abandoned in prsctp | expand

Message

Xin Long Nov. 25, 2017, 1:18 p.m. UTC
Now when abandoning chunks in prsctp, it doesn't consider for frags in
one msg, which would cause peer can never receive the whole frags for
one msg to get them reassembled, these pieces of this msg will stay in
the reasm queue forever and block the following chunks' receiving.

This patchset is to fix them in patch 2 and 3, and also fix another
issue for prsctp in patch 1.

Xin Long (3):
  sctp: only update outstanding_bytes for transmitted queue when doing
    prsctp_prune
  sctp: abandon the whole msg if one part of a fragmented message is
    abandoned
  sctp: do not abandon the other frags in unsent outq if one msg has
    outstanding frags

 include/net/sctp/structs.h |  3 ++-
 net/sctp/chunk.c           | 11 +++++++++++
 net/sctp/outqueue.c        | 19 +++++++++++++------
 3 files changed, 26 insertions(+), 7 deletions(-)

Comments

Neil Horman Nov. 27, 2017, 1:58 p.m. UTC | #1
On Sat, Nov 25, 2017 at 09:18:33PM +0800, Xin Long wrote:
> Now when abandoning chunks in prsctp, it doesn't consider for frags in
> one msg, which would cause peer can never receive the whole frags for
> one msg to get them reassembled, these pieces of this msg will stay in
> the reasm queue forever and block the following chunks' receiving.
> 
> This patchset is to fix them in patch 2 and 3, and also fix another
> issue for prsctp in patch 1.
> 
> Xin Long (3):
>   sctp: only update outstanding_bytes for transmitted queue when doing
>     prsctp_prune
>   sctp: abandon the whole msg if one part of a fragmented message is
>     abandoned
>   sctp: do not abandon the other frags in unsent outq if one msg has
>     outstanding frags
> 
>  include/net/sctp/structs.h |  3 ++-
>  net/sctp/chunk.c           | 11 +++++++++++
>  net/sctp/outqueue.c        | 19 +++++++++++++------
>  3 files changed, 26 insertions(+), 7 deletions(-)
> 
> -- 
> 2.1.0
> 
> 
Series
Acked-by: Neil Horman <nhorman@tuxdriver.com>
David Miller Nov. 27, 2017, 7:52 p.m. UTC | #2
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 25 Nov 2017 21:18:33 +0800

> Now when abandoning chunks in prsctp, it doesn't consider for frags in
> one msg, which would cause peer can never receive the whole frags for
> one msg to get them reassembled, these pieces of this msg will stay in
> the reasm queue forever and block the following chunks' receiving.
> 
> This patchset is to fix them in patch 2 and 3, and also fix another
> issue for prsctp in patch 1.

Series applied, thank you.