mbox series

[net-next,00/15,pull,request] 100GbE Intel Wired LAN Driver Updates 2020-11-02

Message ID 20201102222338.1442081-1-anthony.l.nguyen@intel.com
Headers show
Series 100GbE Intel Wired LAN Driver Updates 2020-11-02 | expand

Message

Tony Nguyen Nov. 2, 2020, 10:23 p.m. UTC 
This series contains updates to ice driver only.

Bruce changes the allocation of ice_flow_prof_params from stack to heap to
avoid excessive stack usage. Corrects a misleading comment and silences a
sparse warning that is not a problem.

Tony renames Flow Director functions to be more generic as their use
is expanded.

Real expands ntuple support to allow for mask values to be specified. This
is done by implementing ACL filtering in HW.

Paul allows for HW initialization to continue if PHY abilities cannot
be obtained.

Jeb removes bypassing FW link override and reading Option ROM and
netlist information for non-E810 devices as this is now available on
other devices.

Nick removes vlan_ena field as this information can be gathered by
checking num_vlan.

Jake combines format strings and debug prints to the same line.

Simon adds a space to fix string concatenation.

The following are changes since commit c43fd36f7fec6c227c5e8a8ddd7d3fe97472182f:
  net: bridge: mcast: fix stub definition of br_multicast_querier_exists
and are available in the git repository at:
  https://github.com/anguy11/next-queue.git 100GbE

Bruce Allan (3):
  ice: cleanup stack hog
  ice: cleanup misleading comment
  ice: silence static analysis warning

Jacob Keller (1):
  ice: join format strings to same line as ice_debug

Jeb Cramer (2):
  ice: Enable Support for FW Override (E82X)
  ice: Remove gate to OROM init

Nick Nunley (1):
  ice: Remove vlan_ena from vsi structure

Paul M Stillwell Jr (1):
  ice: don't always return an error for Get PHY Abilities AQ command

Real Valiquette (5):
  ice: initialize ACL table
  ice: initialize ACL scenario
  ice: create flow profile
  ice: create ACL entry
  ice: program ACL entry

Simon Perron Caissy (1):
  ice: Add space to unknown speed

Tony Nguyen (1):
  ice: rename shared Flow Director functions

 drivers/net/ethernet/intel/ice/Makefile       |    3 +
 drivers/net/ethernet/intel/ice/ice.h          |   26 +-
 drivers/net/ethernet/intel/ice/ice_acl.c      |  482 +++++++
 drivers/net/ethernet/intel/ice/ice_acl.h      |  188 +++
 drivers/net/ethernet/intel/ice/ice_acl_ctrl.c | 1145 +++++++++++++++
 drivers/net/ethernet/intel/ice/ice_acl_main.c |  328 +++++
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  400 +++++-
 drivers/net/ethernet/intel/ice/ice_common.c   |  108 +-
 drivers/net/ethernet/intel/ice/ice_controlq.c |   42 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |    8 +-
 .../net/ethernet/intel/ice/ice_ethtool_fdir.c |  448 ++++--
 drivers/net/ethernet/intel/ice/ice_fdir.c     |   15 +-
 drivers/net/ethernet/intel/ice/ice_fdir.h     |    5 +-
 .../net/ethernet/intel/ice/ice_flex_pipe.c    |   40 +-
 .../net/ethernet/intel/ice/ice_flex_pipe.h    |    7 +
 drivers/net/ethernet/intel/ice/ice_flow.c     | 1253 ++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_flow.h     |   38 +-
 .../net/ethernet/intel/ice/ice_lan_tx_rx.h    |    3 +
 drivers/net/ethernet/intel/ice/ice_lib.c      |   10 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |   70 +-
 drivers/net/ethernet/intel/ice/ice_nvm.c      |   61 +-
 drivers/net/ethernet/intel/ice/ice_sched.c    |   21 +-
 drivers/net/ethernet/intel/ice/ice_switch.c   |   15 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |    5 +
 24 files changed, 4355 insertions(+), 366 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/ice/ice_acl.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_acl.h
 create mode 100644 drivers/net/ethernet/intel/ice/ice_acl_ctrl.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_acl_main.c

Comments

Saeed Mahameed Nov. 2, 2020, 10:58 p.m. UTC | #1 
On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> This series contains updates to ice driver only.

...

> Tony renames Flow Director functions to be more generic as their use
> is expanded.
> 
> Real expands ntuple support to allow for mask values to be specified.
> This
> is done by implementing ACL filtering in HW.
> 

This is a lot of code with only 2 liner commit messages!

Can you please shed more light on what user interface is being used to
program and manage those ACLs, i see it is ethtool from the code but
the cover letter and commit messages do not provide any information 
about that.

Also could you please explain what ethtool interfaces/commands are
being implemented, in the commit messages or cover letter, either is
fine.

Thanks!
Jakub Kicinski Nov. 3, 2020, 10:04 p.m. UTC | #2 
On Mon, 02 Nov 2020 14:58:08 -0800 Saeed Mahameed wrote:
> On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> > This series contains updates to ice driver only.  
> 
> ...
> 
> > Tony renames Flow Director functions to be more generic as their use
> > is expanded.
> > 
> > Real expands ntuple support to allow for mask values to be specified.
> > This
> > is done by implementing ACL filtering in HW.
> >   
> 
> This is a lot of code with only 2 liner commit messages!
> 
> Can you please shed more light on what user interface is being used to
> program and manage those ACLs, i see it is ethtool from the code but
> the cover letter and commit messages do not provide any information 
> about that.
> 
> Also could you please explain what ethtool interfaces/commands are
> being implemented, in the commit messages or cover letter, either is
> fine.

Please remove the defensive programming checks, and preferably slim
down the use of your special return codes.