mbox series

[net-next,0/6] net: ipa: tell GSI the IPA version

Message ID 20201102175400.6282-1-elder@linaro.org
Headers show
Series net: ipa: tell GSI the IPA version | expand

Message

Alex Elder Nov. 2, 2020, 5:53 p.m. UTC 
The GSI code that supports IPA avoids having knowledge about the
IPA layer it serves.  One result of this is that Boolean flags are
used during GSI initialization to convey that certain hardware
version-dependent special behaviors should be used.

A given version of IPA hardware uses a fixed/well-defined version
of GSI, so the IPA version really implies the GSI version.

If given only the IPA version, the GSI code supporting IPA can
use it to implement certain special behaviors required for IPA
*or* GSI.  This avoids the need to pass and maintain numerous
Boolean flags.

Note:  the last patch in this series depends on this patch posted
for review earlier today:
  https://lore.kernel.org/netdev/20201102173435.5987-1-elder@linaro.org

					-Alex

Alex Elder (6):
  net: ipa: expose IPA version to the GSI layer
  net: ipa: record IPA version in GSI structure
  net: ipa: use version in gsi_channel_init()
  net: ipa: use version in gsi_channel_reset()
  net: ipa: use version in gsi_channel_program()
  net: ipa: eliminate legacy arguments

 drivers/net/ipa/gsi.c          | 52 ++++++++++++++++++----------------
 drivers/net/ipa/gsi.h          | 24 +++++++++-------
 drivers/net/ipa/ipa_endpoint.c | 16 ++++-------
 drivers/net/ipa/ipa_main.c     | 14 ++-------
 4 files changed, 51 insertions(+), 55 deletions(-)

Comments

Jakub Kicinski Nov. 5, 2020, 12:31 a.m. UTC | #1 
On Mon,  2 Nov 2020 11:53:54 -0600 Alex Elder wrote:
> The GSI code that supports IPA avoids having knowledge about the
> IPA layer it serves.  One result of this is that Boolean flags are
> used during GSI initialization to convey that certain hardware
> version-dependent special behaviors should be used.
> 
> A given version of IPA hardware uses a fixed/well-defined version
> of GSI, so the IPA version really implies the GSI version.
> 
> If given only the IPA version, the GSI code supporting IPA can
> use it to implement certain special behaviors required for IPA
> *or* GSI.  This avoids the need to pass and maintain numerous
> Boolean flags.

Applied, thanks.

> Note:  the last patch in this series depends on this patch posted
> for review earlier today:
>   https://lore.kernel.org/netdev/20201102173435.5987-1-elder@linaro.org

But in the future please don't post dependent changes like this. The
build bots cannot figure this out and give up on checking your series.
Alex Elder Nov. 5, 2020, 1:40 p.m. UTC | #2 
On 11/4/20 6:31 PM, Jakub Kicinski wrote:
>> Note:  the last patch in this series depends on this patch posted
>> for review earlier today:
>>    https://lore.kernel.org/netdev/20201102173435.5987-1-elder@linaro.org
> But in the future please don't post dependent changes like this. The
> build bots cannot figure this out and give up on checking your series.

Sorry about that, I didn't realize this would be a problem.
I will avoid this in the future.

I will be sending a steady stream of patches in the coming
weeks.  If you have any other comments or suggestions that
would make that easier to manage, please let me know.

Thank you.

					-Alex