mbox series

[v2,0/6] igb: xdp patches followup

Message ID 20201017071238.95190-1-sven.auhagen@voleatech.de
Headers show
Series igb: xdp patches followup | expand

Message

Sven Auhagen Oct. 17, 2020, 7:12 a.m. UTC 
From: Sven Auhagen <sven.auhagen@voleatech.de>

This patch series addresses some of the comments that came back
after the igb XDP patch was accepted.
Most of it is code cleanup.
The last patch contains a fix for a tx queue timeout
that can occur when using xdp.

Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Change from v1:
    * Drop patch 5 as the igb_rx_frame_truesize won't match
    * Fix typo in comment
    * Add Suggested-by and Reviewed-by tags
    * Add how to avoid transmit queue timeout in xdp path
      is fixed in the commit message

Sven Auhagen (6):
  igb: XDP xmit back fix error code
  igb: take vlan double header into account
  igb: XDP extack message on error
  igb: skb add metasize for xdp
  igb: use xdp_do_flush
  igb: avoid transmit queue timeout in xdp path

 drivers/net/ethernet/intel/igb/igb.h      |  5 ++++
 drivers/net/ethernet/intel/igb/igb_main.c | 32 +++++++++++++++--------
 2 files changed, 26 insertions(+), 11 deletions(-)

Comments

Maciej Fijalkowski Oct. 18, 2020, 1:39 p.m. UTC | #1 
On Sat, Oct 17, 2020 at 09:12:32AM +0200, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <sven.auhagen@voleatech.de>
> 
> This patch series addresses some of the comments that came back
> after the igb XDP patch was accepted.
> Most of it is code cleanup.
> The last patch contains a fix for a tx queue timeout
> that can occur when using xdp.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Sorry for not getting back at v1 discussion, I took some time off.

For the series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Couple nits:
- you don't need SOB line within cover letter, I suppose
- next time please specify the tree in the subject that you're targetting
  this set to land; is it net or net-next? net-next is currently closed so
  you probably would have to come back with this once it will be open
  again
- SOB line should be at the end of tags within commit message of patch;
  I'm saying 'should' because I'm not sure if it's hard requirement.

> 
> Change from v1:
>     * Drop patch 5 as the igb_rx_frame_truesize won't match
>     * Fix typo in comment
>     * Add Suggested-by and Reviewed-by tags
>     * Add how to avoid transmit queue timeout in xdp path
>       is fixed in the commit message
> 
> Sven Auhagen (6):
>   igb: XDP xmit back fix error code
>   igb: take vlan double header into account
>   igb: XDP extack message on error
>   igb: skb add metasize for xdp
>   igb: use xdp_do_flush
>   igb: avoid transmit queue timeout in xdp path
> 
>  drivers/net/ethernet/intel/igb/igb.h      |  5 ++++
>  drivers/net/ethernet/intel/igb/igb_main.c | 32 +++++++++++++++--------
>  2 files changed, 26 insertions(+), 11 deletions(-)
> 
> -- 
> 2.20.1
>
Jakub Kicinski Oct. 18, 2020, 7:03 p.m. UTC | #2 
On Sun, 18 Oct 2020 15:39:51 +0200 Maciej Fijalkowski wrote:
> - next time please specify the tree in the subject that you're targetting
>   this set to land; is it net or net-next? net-next is currently closed so
>   you probably would have to come back with this once it will be open
>   again

Most of the patches here look like fixes, so we can take them into net
but please repost them rather soon.
Sven Auhagen Oct. 19, 2020, 5:43 a.m. UTC | #3 
On Sun, Oct 18, 2020 at 03:39:51PM +0200, Maciej Fijalkowski wrote:
> On Sat, Oct 17, 2020 at 09:12:32AM +0200, sven.auhagen@voleatech.de wrote:
> > From: Sven Auhagen <sven.auhagen@voleatech.de>
> > 
> > This patch series addresses some of the comments that came back
> > after the igb XDP patch was accepted.
> > Most of it is code cleanup.
> > The last patch contains a fix for a tx queue timeout
> > that can occur when using xdp.
> > 
> > Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
> 
> Sorry for not getting back at v1 discussion, I took some time off.
> 
> For the series:
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> 
> Couple nits:
> - you don't need SOB line within cover letter, I suppose
> - next time please specify the tree in the subject that you're targetting
>   this set to land; is it net or net-next? net-next is currently closed so
>   you probably would have to come back with this once it will be open
>   again
> - SOB line should be at the end of tags within commit message of patch;
>   I'm saying 'should' because I'm not sure if it's hard requirement.

Thank you, I will fix that and send a v3.

Best
Sven

> 
> > 
> > Change from v1:
> >     * Drop patch 5 as the igb_rx_frame_truesize won't match
> >     * Fix typo in comment
> >     * Add Suggested-by and Reviewed-by tags
> >     * Add how to avoid transmit queue timeout in xdp path
> >       is fixed in the commit message
> > 
> > Sven Auhagen (6):
> >   igb: XDP xmit back fix error code
> >   igb: take vlan double header into account
> >   igb: XDP extack message on error
> >   igb: skb add metasize for xdp
> >   igb: use xdp_do_flush
> >   igb: avoid transmit queue timeout in xdp path
> > 
> >  drivers/net/ethernet/intel/igb/igb.h      |  5 ++++
> >  drivers/net/ethernet/intel/igb/igb_main.c | 32 +++++++++++++++--------
> >  2 files changed, 26 insertions(+), 11 deletions(-)
> > 
> > -- 
> > 2.20.1
> >
Sven Auhagen Oct. 19, 2020, 5:43 a.m. UTC | #4 
On Sun, Oct 18, 2020 at 12:03:36PM -0700, Jakub Kicinski wrote:
> On Sun, 18 Oct 2020 15:39:51 +0200 Maciej Fijalkowski wrote:
> > - next time please specify the tree in the subject that you're targetting
> >   this set to land; is it net or net-next? net-next is currently closed so
> >   you probably would have to come back with this once it will be open
> >   again
> 
> Most of the patches here look like fixes, so we can take them into net
> but please repost them rather soon.

I will repost them today.

Best
Sven