mbox series

[net-next,0/4] simplify TCP loss marking code

Message ID 20200925170431.1099943-1-ycheng@google.com
Headers show
Series simplify TCP loss marking code | expand

Message

Yuchung Cheng Sept. 25, 2020, 5:04 p.m. UTC 
The TCP loss marking is implemented by a set of intertwined
subroutines. TCP has several loss detection algorithms
(RACK, RFC6675/FACK, NewReno, etc) each calls a subset of
these routines to mark a packet lost. This has led to
various bugs (and fixes and fixes of fixes).

This patch set is to consolidate the loss marking code so
all detection algorithms call the same routine tcp_mark_skb_lost().

Yuchung Cheng (4):
  tcp: consistently check retransmit hint
  tcp: move tcp_mark_skb_lost
  tcp: simplify tcp_mark_skb_lost
  tcp: consolidate tcp_mark_skb_lost and tcp_skb_mark_lost

 net/ipv4/tcp_input.c    | 60 +++++++++++++++--------------------------
 net/ipv4/tcp_recovery.c | 16 +----------
 2 files changed, 23 insertions(+), 53 deletions(-)

Comments

David Miller Sept. 26, 2020, 12:17 a.m. UTC | #1 
From: Yuchung Cheng <ycheng@google.com>
Date: Fri, 25 Sep 2020 10:04:27 -0700

> The TCP loss marking is implemented by a set of intertwined
> subroutines. TCP has several loss detection algorithms
> (RACK, RFC6675/FACK, NewReno, etc) each calls a subset of
> these routines to mark a packet lost. This has led to
> various bugs (and fixes and fixes of fixes).
> 
> This patch set is to consolidate the loss marking code so
> all detection algorithms call the same routine tcp_mark_skb_lost().

Looks good, series applied.

Thanks.