mbox series

[net-next,0/2,v2] RTL8366 stabilization

Message ID 20200901190854.15528-1-linus.walleij@linaro.org
Headers show
Series RTL8366 stabilization | expand

Message

Linus Walleij Sept. 1, 2020, 7:08 p.m. UTC 
This stabilizes the RTL8366 driver by checking validity
of the passed VLANs and refactoring the member config
(MC) code so we do not require strict call order and
de-duplicate some code.

Changes from v1: incorporate review comments on patch
2.

Linus Walleij (2):
  net: dsa: rtl8366: Check validity of passed VLANs
  net: dsa: rtl8366: Refactor VLAN/PVID init

 drivers/net/dsa/realtek-smi-core.h |   4 +-
 drivers/net/dsa/rtl8366.c          | 277 +++++++++++++++--------------
 2 files changed, 151 insertions(+), 130 deletions(-)

Comments

David Miller Sept. 1, 2020, 10:39 p.m. UTC | #1 
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue,  1 Sep 2020 21:08:52 +0200

> This stabilizes the RTL8366 driver by checking validity
> of the passed VLANs and refactoring the member config
> (MC) code so we do not require strict call order and
> de-duplicate some code.
> 
> Changes from v1: incorporate review comments on patch
> 2.

Series applied, thank you.
Florian Fainelli Sept. 1, 2020, 10:42 p.m. UTC | #2 
On 9/1/2020 3:39 PM, David Miller wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> Date: Tue,  1 Sep 2020 21:08:52 +0200
> 
>> This stabilizes the RTL8366 driver by checking validity
>> of the passed VLANs and refactoring the member config
>> (MC) code so we do not require strict call order and
>> de-duplicate some code.
>>
>> Changes from v1: incorporate review comments on patch
>> 2.
> 
> Series applied, thank you.

There was a v3 submitted about 30 minutes ago, is that the one you applied?
David Miller Sept. 2, 2020, 12:50 a.m. UTC | #3 
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 1 Sep 2020 15:42:40 -0700

> 
> 
> On 9/1/2020 3:39 PM, David Miller wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>> Date: Tue,  1 Sep 2020 21:08:52 +0200
>> 
>>> This stabilizes the RTL8366 driver by checking validity
>>> of the passed VLANs and refactoring the member config
>>> (MC) code so we do not require strict call order and
>>> de-duplicate some code.
>>>
>>> Changes from v1: incorporate review comments on patch
>>> 2.
>> Series applied, thank you.
> 
> There was a v3 submitted about 30 minutes ago, is that the one you
> applied?

No I applied the v2 :-/