mbox series

[bpf-next,v6,0/2] bpf: cgroup skb improvements for bpf_prog_test_run

Message ID 20200803090545.82046-1-zeil@yandex-team.ru
Headers show
Series bpf: cgroup skb improvements for bpf_prog_test_run | expand

Message

Dmitry Yakunin Aug. 3, 2020, 9:05 a.m. UTC 
This patchset contains some improvements for testing cgroup/skb programs
through BPF_PROG_TEST_RUN command.

v2:
  - fix build without CONFIG_CGROUP_BPF (kernel test robot <lkp@intel.com>)

v3:
  - fix build without CONFIG_IPV6 (kernel test robot <lkp@intel.com>)

v4:
  - remove cgroup storage related commits for future rework (Daniel Borkmann)

v5:
  - check skb length before access to inet headers (Eric Dumazet)

v6:
  - do not use pskb_may_pull() in skb length checking (Alexei Starovoitov)

Dmitry Yakunin (2):
  bpf: setup socket family and addresses in bpf_prog_test_run_skb
  bpf: allow to specify ifindex for skb in bpf_prog_test_run_skb

 net/bpf/test_run.c                               | 39 ++++++++++++++++++++++--
 tools/testing/selftests/bpf/prog_tests/skb_ctx.c |  5 +++
 2 files changed, 42 insertions(+), 2 deletions(-)

Comments

Daniel Borkmann Aug. 3, 2020, 9:55 p.m. UTC | #1 
On 8/3/20 11:05 AM, Dmitry Yakunin wrote:
> This patchset contains some improvements for testing cgroup/skb programs
> through BPF_PROG_TEST_RUN command.
> 
> v2:
>    - fix build without CONFIG_CGROUP_BPF (kernel test robot <lkp@intel.com>)
> 
> v3:
>    - fix build without CONFIG_IPV6 (kernel test robot <lkp@intel.com>)
> 
> v4:
>    - remove cgroup storage related commits for future rework (Daniel Borkmann)
> 
> v5:
>    - check skb length before access to inet headers (Eric Dumazet)
> 
> v6:
>    - do not use pskb_may_pull() in skb length checking (Alexei Starovoitov)
> 
> Dmitry Yakunin (2):
>    bpf: setup socket family and addresses in bpf_prog_test_run_skb
>    bpf: allow to specify ifindex for skb in bpf_prog_test_run_skb
> 
>   net/bpf/test_run.c                               | 39 ++++++++++++++++++++++--
>   tools/testing/selftests/bpf/prog_tests/skb_ctx.c |  5 +++
>   2 files changed, 42 insertions(+), 2 deletions(-)
> 

Looks good, applied, thanks!