mbox series

[net,0/2] sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket is closed

Message ID 20200421190342.548226-1-jere.leppanen@nokia.com
Headers show
Series sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket is closed | expand

Message

Jere Leppänen April 21, 2020, 7:03 p.m. UTC 
These patches are related to the scenario described in commit
bdf6fa52f01b ("sctp: handle association restarts when the socket is
closed."). To recap, when our association is in SHUTDOWN-PENDING state
and we've closed our one-to-one socket, while the peer crashes without
being detected, restarts and reconnects using the same addresses and
ports, we start association shutdown.

In this case, Cumulative TSN Ack in the SHUTDOWN that we send has
always been incorrect. Additionally, bundling of the SHUTDOWN with the
COOKIE-ACK was broken by a later commit. This series fixes both of
these issues.

Jere Leppänen (2):
  sctp: Fix bundling of SHUTDOWN with COOKIE-ACK
  sctp: Fix SHUTDOWN CTSN Ack in the peer restart case

 net/sctp/sm_make_chunk.c | 6 +++++-
 net/sctp/sm_statefuns.c  | 6 +++---
 2 files changed, 8 insertions(+), 4 deletions(-)


base-commit: a460fc5d4c170806a31e590df37ead3ab951315c

Comments

David Miller April 23, 2020, 2:28 a.m. UTC | #1 
From: Jere Leppänen <jere.leppanen@nokia.com>
Date: Tue, 21 Apr 2020 22:03:40 +0300

> These patches are related to the scenario described in commit
> bdf6fa52f01b ("sctp: handle association restarts when the socket is
> closed."). To recap, when our association is in SHUTDOWN-PENDING state
> and we've closed our one-to-one socket, while the peer crashes without
> being detected, restarts and reconnects using the same addresses and
> ports, we start association shutdown.
> 
> In this case, Cumulative TSN Ack in the SHUTDOWN that we send has
> always been incorrect. Additionally, bundling of the SHUTDOWN with the
> COOKIE-ACK was broken by a later commit. This series fixes both of
> these issues.

Series applied, thanks.