From patchwork Tue Apr 14 18:20:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1270646 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 491v2d06XRz9sSk for ; Wed, 15 Apr 2020 04:21:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503811AbgDNSVk (ORCPT ); Tue, 14 Apr 2020 14:21:40 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:48979 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503784AbgDNSVI (ORCPT ); Tue, 14 Apr 2020 14:21:08 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 491v1q4lsxz1qrgD; Tue, 14 Apr 2020 20:20:59 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 491v1l5hsKz1qqkS; Tue, 14 Apr 2020 20:20:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id MlPEXFt8ek6S; Tue, 14 Apr 2020 20:20:58 +0200 (CEST) X-Auth-Info: koY5XDuTA8EobSmshiUWaxSyyB8yiTt7wlPoK88R5Y8= Received: from desktop.lan (ip-86-49-35-8.net.upcbroadband.cz [86.49.35.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 14 Apr 2020 20:20:58 +0200 (CEST) From: Marek Vasut To: netdev@vger.kernel.org Cc: Marek Vasut , "David S . Miller" , Lukas Wunner , Petr Stetiar , YueHaibing Subject: [PATCH V4 00/19] net: ks8851: Unify KS8851 SPI and MLL drivers Date: Tue, 14 Apr 2020 20:20:10 +0200 Message-Id: <20200414182029.183594-1-marex@denx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces of silicon, except the former has an SPI interface, while the later has a parallel bus interface. Thus far, Linux has two separate drivers for each and they are diverging considerably. This series unifies them into a single driver with small SPI and parallel bus specific parts. The approach here is to first separate out the SPI specific parts into a separate file, then add parallel bus accessors in another separate file and then finally remove the old parallel bus driver. The reason for replacing the old parallel bus driver is because the SPI bus driver is much higher quality. NOTE: The performance regression on KS8851-16MLL is now fixed, the TX throughput is back to ~75 Mbit/s , RX is still 50 Mbit/s . NOTE: The V4 is now tested on RPi3B with KSZ8851SNL DEMO Board at 25 MHz. The "ping -c 1000 -i 0.01" latency test is fluctuating around rtt min/avg/max/mdev = 1.448/1.540/1.699/0.030 ms either way, with or without this series. The following chunk was added to arch/arm/boot/dts/bcm2837-rpi-3-b.dts to bind the KSZ8851SNL on the RPi3B: &spi { status = "okay"; cs-gpios = <&gpio 8 1>; pinctrl-names = "default"; pinctrl-0 = <&spi0_gpio7>; ks8851@0 { compatible = "ks8851"; spi-max-frequency = <25000000>; reg = <0>; interrupt-parent = <&gpio>; interrupts = <25 IRQ_TYPE_EDGE_FALLING>; }; }; Marek Vasut (19): net: ks8851: Factor out spi->dev in probe()/remove() net: ks8851: Rename ndev to netdev in probe net: ks8851: Replace dev_err() with netdev_err() in IRQ handler net: ks8851: Pass device node into ks8851_init_mac() net: ks8851: Use devm_alloc_etherdev() net: ks8851: Use dev_{get,set}_drvdata() net: ks8851: Remove ks8851_rdreg32() net: ks8851: Use 16-bit writes to program MAC address net: ks8851: Use 16-bit read of RXFC register net: ks8851: Factor out bus lock handling net: ks8851: Factor out SKB receive function net: ks8851: Split out SPI specific entries in struct ks8851_net net: ks8851: Split out SPI specific code from probe() and remove() net: ks8851: Factor out TX work flush function net: ks8851: Permit overridding interrupt enable register net: ks8851: Implement register, FIFO, lock accessor callbacks net: ks8851: Separate SPI operations into separate file net: ks8851: Implement Parallel bus operations net: ks8851: Remove ks8851_mll.c drivers/net/ethernet/micrel/Kconfig | 2 + drivers/net/ethernet/micrel/Makefile | 2 + drivers/net/ethernet/micrel/ks8851.h | 140 +- .../micrel/{ks8851.c => ks8851_common.c} | 686 ++------ drivers/net/ethernet/micrel/ks8851_mll.c | 1393 ----------------- drivers/net/ethernet/micrel/ks8851_par.c | 343 ++++ drivers/net/ethernet/micrel/ks8851_spi.c | 476 ++++++ 7 files changed, 1097 insertions(+), 1945 deletions(-) rename drivers/net/ethernet/micrel/{ks8851.c => ks8851_common.c} (62%) delete mode 100644 drivers/net/ethernet/micrel/ks8851_mll.c create mode 100644 drivers/net/ethernet/micrel/ks8851_par.c create mode 100644 drivers/net/ethernet/micrel/ks8851_spi.c Signed-off-by: Marek Vasut Cc: David S. Miller Cc: Lukas Wunner Cc: Petr Stetiar Cc: YueHaibing