From patchwork Sun Mar 29 18:21:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1263523 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=BUUa7Q0+; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48r3pL08jcz9sP7 for ; Mon, 30 Mar 2020 05:22:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbgC2SWA (ORCPT ); Sun, 29 Mar 2020 14:22:00 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:36003 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727719AbgC2SWA (ORCPT ); Sun, 29 Mar 2020 14:22:00 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 0D3BB580907; Sun, 29 Mar 2020 14:21:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 29 Mar 2020 14:21:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=11lbQrp0c1TFo3Ep3 Esk4AVxO3aIjoZ/RjqSLUSJu2A=; b=BUUa7Q0+Q4JssDn2s1uYmvQ/Z1sNL4pET muGJ30uspVoK2ejmJ9AhToMDK0Y4MlmfEkIl1A7JCEUkyn7xr6+WZMEC22105y+1 qlJFCAxCkruzlkWctoR3RzTiLd4SHu0kEmfh/brNtlathamktRg0tmI0uDy1xjO6 okRUUDSisBRs58T1xLrcqoOIklxAqWSTaFzPdxyX74TFyg2JMC2oA5FG+0a0o+rz 04Yk+9cfrvvrxWZY3EP8TxmuZ6+Ki7kKqxtEbPCqgAAxg4ML5UN9o8uwYFeiVwSc MpkRnqLyo9dARaz5jdxW5VYyZDGgP2M5XkdsFtAXQT3xA2T3DhPdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeifedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhs tghhrdhorhhgqeenucfkphepjeelrddukedurddufedvrdduledunecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgt hhdrohhrgh X-ME-Proxy: Received: from splinter.mtl.com (bzq-79-181-132-191.red.bezeqint.net [79.181.132.191]) by mail.messagingengine.com (Postfix) with ESMTPA id 504093280060; Sun, 29 Mar 2020 14:21:55 -0400 (EDT) From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next v2 00/15] Add packet trap policers support Date: Sun, 29 Mar 2020 21:21:04 +0300 Message-Id: <20200329182119.2207630-1-idosch@idosch.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Background ========== Devices capable of offloading the kernel's datapath and perform functions such as bridging and routing must also be able to send (trap) specific packets to the kernel (i.e., the CPU) for processing. For example, a device acting as a multicast-aware bridge must be able to trap IGMP membership reports to the kernel for processing by the bridge module. Motivation ========== In most cases, the underlying device is capable of handling packet rates that are several orders of magnitude higher compared to those that can be handled by the CPU. Therefore, in order to prevent the underlying device from overwhelming the CPU, devices usually include packet trap policers that are able to police the trapped packets to rates that can be handled by the CPU. Proposed solution ================= This patch set allows capable device drivers to register their supported packet trap policers with devlink. User space can then tune the parameters of these policers (currently, rate and burst size) and read from the device the number of packets that were dropped by the policer, if supported. These packet trap policers can then be bound to existing packet trap groups, which are used to aggregate logically related packet traps. As a result, trapped packets are policed to rates that can be handled the host CPU. Example usage ============= Instantiate netdevsim: # echo "10 1" > /sys/bus/netdevsim/new_device Dump available packet trap policers: # devlink trap policer show netdevsim/netdevsim10: policer 1 rate 1000 burst 128 policer 2 rate 2000 burst 256 policer 3 rate 3000 burst 512 Change the parameters of a packet trap policer: # devlink trap policer set netdevsim/netdevsim10 policer 3 rate 100 burst 16 Bind a packet trap policer to a packet trap group: # devlink trap group set netdevsim/netdevsim10 group acl_drops policer 3 Dump parameters and statistics of a packet trap policer: # devlink -s trap policer show netdevsim/netdevsim10 policer 3 netdevsim/netdevsim10: policer 3 rate 100 burst 16 stats: rx: dropped 92 Unbind a packet trap policer from a packet trap group: # devlink trap group set netdevsim/netdevsim10 group acl_drops nopolicer Patch set overview ================== Patch #1 adds the core infrastructure in devlink which allows capable device drivers to register their supported packet trap policers with devlink. Patch #2 extends the existing devlink-trap documentation. Patch #3 extends netdevsim to register a few dummy packet trap policers with devlink. Used later on to selftests the core infrastructure. Patches #4-#5 adds infrastructure in devlink to allow binding of packet trap policers to packet trap groups. Patch #6 extends netdevsim to allow such binding. Patch #7 adds a selftest over netdevsim that verifies the core devlink-trap policers functionality. Patches #8-#14 gradually add devlink-trap policers support in mlxsw. Patch #15 adds a selftest over mlxsw. All registered packet trap policers are verified to handle the configured rate and burst size. Future plans ============ * Allow changing default association between packet traps and packet trap groups * Add more packet traps. For example, for control packets (e.g., IGMP) v2 (address comments from Jiri and Jakub): * Patch #1: Add 'strict_start_type' in devlink policy * Patch #1: Have device drivers provide max/min rate/burst size for each policer. Use them to check validity of user provided parameters * Patch #3: Remove check about burst size being a power of 2 and instead add a debugfs knob to fail the operation * Patch #3: Provide max/min rate/burst size when registering policers and remove the validity checks from nsim_dev_devlink_trap_policer_set() * Patch #5: Check for presence of 'DEVLINK_ATTR_TRAP_POLICER_ID' in devlink_trap_group_set() and bail if not present * Patch #5: Add extack error message in case trap group was partially modified * Patch #7: Add test case with new 'fail_trap_policer_set' knob * Patch #7: Add test case for partially modified trap group * Patch #10: Provide max/min rate/burst size when registering policers * Patch #11: Remove the max/min validity checks from __mlxsw_sp_trap_policer_set() Ido Schimmel (15): devlink: Add packet trap policers support Documentation: Add description of packet trap policers netdevsim: Add devlink-trap policer support devlink: Add packet trap group parameters support devlink: Allow setting of packet trap group parameters netdevsim: Add support for setting of packet trap group parameters selftests: netdevsim: Add test cases for devlink-trap policers mlxsw: reg: Extend QPCR register mlxsw: spectrum: Track used packet trap policer IDs mlxsw: spectrum_trap: Prepare policers for registration with devlink mlxsw: spectrum_trap: Add devlink-trap policer support mlxsw: spectrum_trap: Do not initialize dedicated discard policer mlxsw: spectrum_trap: Switch to use correct packet trap group mlxsw: spectrum_trap: Add support for setting of packet trap group parameters selftests: mlxsw: Add test cases for devlink-trap policers .../networking/devlink/devlink-trap.rst | 26 + drivers/net/ethernet/mellanox/mlxsw/core.c | 71 +++ drivers/net/ethernet/mellanox/mlxsw/core.h | 14 + drivers/net/ethernet/mellanox/mlxsw/reg.h | 19 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 50 +- .../net/ethernet/mellanox/mlxsw/spectrum.h | 17 + .../ethernet/mellanox/mlxsw/spectrum_trap.c | 336 ++++++++++-- .../ethernet/mellanox/mlxsw/spectrum_trap.h | 24 + drivers/net/netdevsim/dev.c | 110 +++- drivers/net/netdevsim/netdevsim.h | 3 + include/net/devlink.h | 90 ++- include/uapi/linux/devlink.h | 11 + net/core/devlink.c | 515 +++++++++++++++++- .../drivers/net/mlxsw/devlink_trap_policer.sh | 384 +++++++++++++ .../drivers/net/netdevsim/devlink_trap.sh | 116 ++++ .../selftests/net/forwarding/devlink_lib.sh | 43 ++ 16 files changed, 1778 insertions(+), 51 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.h create mode 100755 tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh