| Message ID | 20200327085525.1906170-1-idosch@idosch.org |
|---|---|
| Headers | show |
| Series | mlxsw: Various static checkers fixes | expand |
From: Ido Schimmel <idosch@idosch.org> Date: Fri, 27 Mar 2020 11:55:19 +0300 > From: Ido Schimmel <idosch@mellanox.com> > > Jakub told me he gets some warnings with W=1, so I decided to check with > sparse, smatch and coccinelle as well. This patch set fixes all the > issues found. None are actual bugs / regressions and therefore not > targeted at net. > > Patches #1-#2 add missing kernel-doc comments. > > Patch #3 removes dead code. > > Patch #4 reworks the ACL code to avoid defining a static variable in a > header file. > > Patch #5 removes unnecessary conversion to bool that coccinelle warns > about. > > Patch #6 avoids false-positive uninitialized symbol errors emitted by > smatch. Series applied, thanks Ido.
From: Ido Schimmel <idosch@mellanox.com> Jakub told me he gets some warnings with W=1, so I decided to check with sparse, smatch and coccinelle as well. This patch set fixes all the issues found. None are actual bugs / regressions and therefore not targeted at net. Patches #1-#2 add missing kernel-doc comments. Patch #3 removes dead code. Patch #4 reworks the ACL code to avoid defining a static variable in a header file. Patch #5 removes unnecessary conversion to bool that coccinelle warns about. Patch #6 avoids false-positive uninitialized symbol errors emitted by smatch. Ido Schimmel (6): mlxsw: i2c: Add missing field documentation mlxsw: spectrum_router: Add proper function documentation mlxsw: spectrum: Remove unused RIF and FID families mlxsw: core_acl: Avoid defining static variable in header file mlxsw: switchx2: Remove unnecessary conversion to bool mlxsw: spectrum_router: Avoid uninitialized symbol errors .../mellanox/mlxsw/core_acl_flex_keys.c | 50 +++++- .../mellanox/mlxsw/core_acl_flex_keys.h | 36 +--- drivers/net/ethernet/mellanox/mlxsw/i2c.c | 1 + .../ethernet/mellanox/mlxsw/spectrum_fid.c | 152 +--------------- .../ethernet/mellanox/mlxsw/spectrum_router.c | 164 ++++++------------ .../net/ethernet/mellanox/mlxsw/switchx2.c | 2 +- 6 files changed, 109 insertions(+), 296 deletions(-)