| Message ID | 20200320112303.81904-1-nikolay@cumulusnetworks.com |
|---|---|
| Headers | show |
| Series | net: bridge: vlan options: nest the tunnel options | expand |
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Date: Fri, 20 Mar 2020 13:23:01 +0200 > After a discussion with Roopa about the new tunnel vlan option, she > suggested that we'll be adding more tunnel options and attributes, so > it'd be better to have them all grouped together under one main vlan > entry tunnel attribute instead of making them all main attributes. Since > the tunnel code was added in this net-next cycle and still hasn't been > released we can easily nest the BRIDGE_VLANDB_ENTRY_TUNNEL_ID attribute > in BRIDGE_VLANDB_ENTRY_TUNNEL_INFO and allow for any new tunnel > attributes to be added there. In addition one positive side-effect is > that we can remove the outside vlan info flag which controlled the > operation (setlink/dellink) and move it under a new nested attribute so > user-space can specify it explicitly. > > Thus the vlan tunnel format becomes: > [BRIDGE_VLANDB_ENTRY] > [BRIDGE_VLANDB_ENTRY_TUNNEL_INFO] > [BRIDGE_VLANDB_TINFO_ID] > [BRIDGE_VLANDB_TINFO_CMD] > ... Makes sense, series applied, thanks.
Hi, After a discussion with Roopa about the new tunnel vlan option, she suggested that we'll be adding more tunnel options and attributes, so it'd be better to have them all grouped together under one main vlan entry tunnel attribute instead of making them all main attributes. Since the tunnel code was added in this net-next cycle and still hasn't been released we can easily nest the BRIDGE_VLANDB_ENTRY_TUNNEL_ID attribute in BRIDGE_VLANDB_ENTRY_TUNNEL_INFO and allow for any new tunnel attributes to be added there. In addition one positive side-effect is that we can remove the outside vlan info flag which controlled the operation (setlink/dellink) and move it under a new nested attribute so user-space can specify it explicitly. Thus the vlan tunnel format becomes: [BRIDGE_VLANDB_ENTRY] [BRIDGE_VLANDB_ENTRY_TUNNEL_INFO] [BRIDGE_VLANDB_TINFO_ID] [BRIDGE_VLANDB_TINFO_CMD] ... Thanks, Nik Nikolay Aleksandrov (2): net: bridge: vlan options: nest the tunnel id into a tunnel info attribute net: bridge: vlan options: move the tunnel command to the nested attribute include/uapi/linux/if_bridge.h | 18 +++++++- net/bridge/br_vlan.c | 2 +- net/bridge/br_vlan_options.c | 76 +++++++++++++++++++++++++--------- 3 files changed, 74 insertions(+), 22 deletions(-)