mbox series

[bpf-next,0/2] Fixes for bpftool-prog-profile

Message ID 20200310183624.441788-1-songliubraving@fb.com
Headers show
Series Fixes for bpftool-prog-profile | expand

Message

Song Liu March 10, 2020, 6:36 p.m. UTC 
1. Fix build for older clang;
2. Fix skeleton's dependency on libbpf.

Song Liu (2):
  bpftool: only build bpftool-prog-profile with clang >= v11
  bpftool: skeleton should depend on libbpf

 tools/bpf/bpftool/Makefile | 15 ++++++++++++---
 tools/bpf/bpftool/prog.c   |  2 ++
 2 files changed, 14 insertions(+), 3 deletions(-)

--
2.17.1

Comments

John Fastabend March 10, 2020, 10 p.m. UTC | #1 
Song Liu wrote:
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf.
> 
> Song Liu (2):
>   bpftool: only build bpftool-prog-profile with clang >= v11
>   bpftool: skeleton should depend on libbpf
> 
>  tools/bpf/bpftool/Makefile | 15 ++++++++++++---
>  tools/bpf/bpftool/prog.c   |  2 ++
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> --
> 2.17.1

Maybe instead of "Please recompile" -> "Please build" sounds a bit better
to me but that is probably a matter of preference and doesn't matter much.

Anyways for the series,

Acked-by: John Fastabend <john.fastabend@gmail.com>
Andrii Nakryiko March 11, 2020, 4:33 a.m. UTC | #2 
On Tue, Mar 10, 2020 at 11:36 AM Song Liu <songliubraving@fb.com> wrote:
>
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf.
>

Can you please also add tools/bpf/bpftool/profiler.skel.h to .gitignore?

> Song Liu (2):
>   bpftool: only build bpftool-prog-profile with clang >= v11
>   bpftool: skeleton should depend on libbpf
>
>  tools/bpf/bpftool/Makefile | 15 ++++++++++++---
>  tools/bpf/bpftool/prog.c   |  2 ++
>  2 files changed, 14 insertions(+), 3 deletions(-)
>
> --
> 2.17.1