mbox series

[bpf-next,v2,0/5] bpftool: Make probes which emit dmesg warnings optional

Message ID 20200221031702.25292-1-mrostecki@opensuse.org
Headers show
Series bpftool: Make probes which emit dmesg warnings optional | expand

Message

Michal Rostecki Feb. 21, 2020, 3:16 a.m. UTC 
Feature probes in bpftool related to bpf_probe_write_user and
bpf_trace_printk helpers emit dmesg warnings which might be confusing
for people running bpftool on production environments. This patch series
addresses that by filtering them out by default and introducing the new
positional argument "full" which enables all available probes.

The main motivation behind those changes is ability the fact that some
probes (for example those related to "trace" or "write_user" helpers)
emit dmesg messages which might be confusing for people who are running
on production environments. For details see the Cilium issue[0].

v1: https://lore.kernel.org/bpf/20200218190224.22508-1-mrostecki@opensuse.org/T/

v1 -> v2:
- Do not expose regex filters to users, keep filtering logic internal,
expose only the "full" option for including probes which emit dmesg
warnings.

[0] https://github.com/cilium/cilium/issues/10048

Michal Rostecki (5):
  bpftool: Move out sections to separate functions
  bpftool: Make probes which emit dmesg warnings optional
  bpftool: Update documentation of "bpftool feature" command
  bpftool: Update bash completion for "bpftool feature" command
  selftests/bpf: Add test for "bpftool feature" command

 .../bpftool/Documentation/bpftool-feature.rst |  15 +-
 tools/bpf/bpftool/bash-completion/bpftool     |  27 +-
 tools/bpf/bpftool/feature.c                   | 291 ++++++++++++------
 tools/testing/selftests/.gitignore            |   5 +-
 tools/testing/selftests/bpf/Makefile          |   3 +-
 tools/testing/selftests/bpf/test_bpftool.py   | 228 ++++++++++++++
 tools/testing/selftests/bpf/test_bpftool.sh   |   5 +
 7 files changed, 463 insertions(+), 111 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/test_bpftool.py
 create mode 100755 tools/testing/selftests/bpf/test_bpftool.sh